net/websockets/websocket_stream_cookie_test.cc - Issue 1233453011: Revert of Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_stream_cookie_test.cc

Issue 1233453011: Revert of Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/websockets/websocket_stream_cookie_test.cc

diff --git a/net/websockets/websocket_stream_cookie_test.cc b/net/websockets/websocket_stream_cookie_test.cc

index d1f41a75b4279e51d7bf4d620e9476b8e0d2e7cd..8e4d9c4ecceb4f8c9dad0ae44a842eddaedfef90 100644

--- a/net/websockets/websocket_stream_cookie_test.cc

+++ b/net/websockets/websocket_stream_cookie_test.cc

@@ -35,8 +35,7 @@

// We assume cookie_header ends with CRLF if not empty, as

// WebSocketStandardRequestWithCookies requires. Use AddCRLFIfNotEmpty

// in a call site.

- CHECK(cookie_header.empty() ||

- base::EndsWith(cookie_header, "\r\n", base::CompareCase::SENSITIVE));

+ CHECK(cookie_header.empty() || base::EndsWith(cookie_header, "\r\n", true));

url_request_context_host_.SetExpectations(

WebSocketStandardRequestWithCookies(url.path(), url.host(), origin,

« no previous file with comments | « net/tools/flip_server/mem_cache.cc ('k') | pdf/document_loader.cc » ('j') | no next file with comments »