third_party/zlib/google/zip_reader.cc - Issue 1233453011: Revert of Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/zlib/google/zip_reader.cc

Issue 1233453011: Revert of Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/zlib/google/zip_reader.cc

diff --git a/third_party/zlib/google/zip_reader.cc b/third_party/zlib/google/zip_reader.cc

index e0871c85367321c785c31383f8cf8d2a28000027..d3c2775844a5ddb1dc687c8d72c2cac17b449bca 100644

--- a/third_party/zlib/google/zip_reader.cc

+++ b/third_party/zlib/google/zip_reader.cc

@@ -131,8 +131,7 @@

original_size_ = raw_file_info.uncompressed_size;

// Directory entries in zip files end with "/".

- is_directory_ = base::EndsWith(file_name_in_zip, "/",

- base::CompareCase::INSENSITIVE_ASCII);

+ is_directory_ = base::EndsWith(file_name_in_zip, "/", false);

// Check the file name here for directory traversal issues.

is_unsafe_ = file_path_.ReferencesParent();

« no previous file with comments | « remoting/host/remoting_me2me_host.cc ('k') | tools/gn/ninja_binary_target_writer.cc » ('j') | no next file with comments »