chrome/common/service_process_util_unittest.cc - Issue 1233453011: Revert of Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_unittest.cc

Issue 1233453011: Revert of Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/service_process_util_unittest.cc

diff --git a/chrome/common/service_process_util_unittest.cc b/chrome/common/service_process_util_unittest.cc

index 14af917e191bf8ddd0d9fa01c92438d849e1c7b5..3f75249f90d9aacaa4f99f20462c0f7e495ce68f 100644

--- a/chrome/common/service_process_util_unittest.cc

+++ b/chrome/common/service_process_util_unittest.cc

@@ -63,8 +63,7 @@

std::string test_str = "test";

std::string scoped_name = GetServiceProcessScopedVersionedName(test_str);

chrome::VersionInfo version_info;

- EXPECT_TRUE(base::EndsWith(scoped_name, test_str,

- base::CompareCase::SENSITIVE));

+ EXPECT_TRUE(base::EndsWith(scoped_name, test_str, true));

EXPECT_NE(std::string::npos, scoped_name.find(version_info.Version()));

}

« no previous file with comments | « chrome/common/importer/firefox_importer_utils.cc ('k') | chrome/installer/gcapi/gcapi.cc » ('j') | no next file with comments »