chrome/browser/banners/app_banner_data_fetcher.cc - Issue 1233453011: Revert of Remove some legacy versions of StartsWith and EndsWith.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher.cc

Issue 1233453011: Revert of Remove some legacy versions of StartsWith and EndsWith. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/banners/app_banner_data_fetcher.cc

diff --git a/chrome/browser/banners/app_banner_data_fetcher.cc b/chrome/browser/banners/app_banner_data_fetcher.cc

index c61385b573431afd2ef0da189d8616aeea10822e..d926ed3893f854456d14e81b7dd65ca5a3925fd5 100644

--- a/chrome/browser/banners/app_banner_data_fetcher.cc

+++ b/chrome/browser/banners/app_banner_data_fetcher.cc

@@ -40,8 +40,7 @@

// the src extension, and allow the icon if the extension ends with png.

if (!base::EqualsASCII(icon.type.string(), "image/png") &&

!(icon.type.is_null() &&

- base::EndsWith(icon.src.ExtractFileName(), kPngExtension,

- base::CompareCase::INSENSITIVE_ASCII)))

+ base::EndsWith(icon.src.ExtractFileName(), kPngExtension, false)))

continue;

for (const auto& size : icon.sizes) {

« no previous file with comments | « chrome/app/delay_load_hook_win.cc ('k') | chrome/browser/chromeos/extensions/wallpaper_private_api.cc » ('j') | no next file with comments »