Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4202)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/toolchain/win/midl.gni

Issue 1233453008: Enable -Wextra-tokens on win clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | google_update/google_update.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/midl.gni
diff --git a/build/toolchain/win/midl.gni b/build/toolchain/win/midl.gni
index 197f3668e309a1ea3bbaed49dc7200e18a1bf9a9..3e7fbecca5392a51730a24617d55bd1fc52dad07 100644
--- a/build/toolchain/win/midl.gni
+++ b/build/toolchain/win/midl.gni
@@ -101,5 +101,13 @@ template("midl") {
public_deps = [
":$action_name",
]
+
+ config("midl_warnings") {
+ if (is_clang) {
+ # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_"
+ cflags = [ "-Wno-extra-tokens" ]
+ }
+ }
+ configs += [ ":midl_warnings" ]
}
}
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | google_update/google_update.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698