Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1233453008: Enable -Wextra-tokens on win clang. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, plundblad+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable -Wextra-tokens on win clang. This warns on code of the form: #endif RANDOM_TEXT MIDL generated code tends to emit code in this pattern, so suppress this warning when compiling MIDL generated files. BUG=504663 R=thakis@chromium.org TBR=dtseng, robertshield, weitaosu Committed: https://chromium.googlesource.com/chromium/src/+/be8d6f52672bf61324b2ac988ef7776ade9d1628

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M build/common.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/toolchain/win/midl.gni View 1 chunk +8 lines, -0 lines 0 comments Download
M google_update/google_update.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M remoting/remoting_host_win.gypi View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/iaccessible2/iaccessible2.gyp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/isimpledom/isimpledom.gyp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dcheng
5 years, 5 months ago (2015-07-11 01:38:56 UTC) #2
Nico
lgtm, nice :-) Bonus for filing a microsoft connect bug so that midl hopefully eventually ...
5 years, 5 months ago (2015-07-11 03:32:50 UTC) #3
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/be8d6f52672bf61324b2ac988ef7776ade9d1628 Cr-Commit-Position: refs/heads/master@{#338435}
5 years, 5 months ago (2015-07-11 05:18:50 UTC) #5
dcheng
5 years, 5 months ago (2015-07-11 05:25:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
be8d6f52672bf61324b2ac988ef7776ade9d1628 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698