Issue 1233453006: Merge 197139 "Fix the logic that limits the number of frames in ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1233453006: Merge 197139 "Fix the logic that limits the number of frames in ..." (Closed)

Created:
5 years, 5 months ago by Nate Chapin

Modified:
5 years, 5 months ago

Reviewers:
Nate Chapin

CC:
blink-reviews, blink-reviews-html_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2403/

Project:
SWITCH_TO_GIT_ALREADY

Visibility:
Public.

More Reviews

Description

Merge 197139 "Fix the logic that limits the number of frames in ..." > Fix the logic that limits the number of frames in a page. > > This check apparently doesn't run soon enough, and we can create more than the > intended limit of 1000 frames. Once we hit 1024, > NodeRareData::m_connecetedFrameCount can overflow and we no longer fully detach > Frames from their owners at teardown. > > BUG=493243 > TEST=WebFrameTest.MaxFramesDetach > > Review URL: https://codereview.chromium.org/1180603002 TBR=japhet@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198702

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -5 lines)			Patch
M	Source/core/dom/NodeRareData.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/core/dom/NodeRareData.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/core/frame/LocalFrame.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/html/HTMLFrameOwnerElement.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/web/tests/WebFrameTest.cpp	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A +	Source/web/tests/data/max-frames-detach.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r198702.

Expand Messages | Collapse Messages