Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 1233453005: Remove pubspec.yamls for sky/sdk/example (Closed)

Created:
5 years, 5 months ago by abarth-chromium
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, gregsimon, jackson_old, eseidel1
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove pubspec.yamls for sky/sdk/example As long as these examples are part of sky/sdk, they don't need pubspec.yamls because they inherit them from sky/sdk/pubspec.yaml. Eventually we'll want to move these examples to their own repo, but we're not ready for that yet. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/bd24055c364fa8dfe1cca8f2dd8812b08f4f0e07

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -34 lines) Patch
D sky/sdk/example/fitness/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/sdk/example/game/pubspec.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/sdk/example/hello_world/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/sdk/example/mine_digger/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download
D sky/sdk/example/raw/pubspec.yaml View 1 chunk +0 lines, -3 lines 0 comments Download
D sky/sdk/example/stocks/pubspec.yaml View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 5 months ago (2015-07-10 16:38:30 UTC) #1
Cutch
lgtm
5 years, 5 months ago (2015-07-10 16:47:56 UTC) #2
abarth-chromium
5 years, 5 months ago (2015-07-10 16:48:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd24055c364fa8dfe1cca8f2dd8812b08f4f0e07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698