Allow asynchronous tab creation when opener_suppressed is true.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
@@ skipping 1738 matching lines @@
           this, new_contents, params.disposition, initial_rect,
           params.user_gesture, &was_blocked);
     }
     if (!was_blocked) {
       OpenURLParams open_params(params.target_url,
                                 Referrer(),
                                 CURRENT_TAB,
                                 ui::PAGE_TRANSITION_LINK,
                                 true /* is_renderer_initiated */);
       open_params.user_gesture = params.user_gesture;
-      new_contents->OpenURL(open_params);
+
+      if (delegate_ && !is_guest &&
+          !delegate_->ShouldResumeRequestsForCreatedWindow()) {
+        // We are in asynchronous add new contents path, delay opening url
+        new_contents->delayed_open_url_params_.reset(
+            new OpenURLParams(open_params));
+      } else {
+        new_contents->OpenURL(open_params);
+      }
     }
   }
 }
 
 void WebContentsImpl::CreateNewWidget(int render_process_id,
                                       int route_id,
                                       blink::WebPopupType popup_type) {
   CreateNewWidget(render_process_id, route_id, false, popup_type);
 }
 
@@ skipping 892 matching lines @@
   manifest_manager_host_->GetManifest(GetMainFrame(), callback);
 }
 
 void WebContentsImpl::ExitFullscreen() {
   // Clean up related state and initiate the fullscreen exit.
   GetRenderViewHost()->RejectMouseLockOrUnlockIfNecessary();
   ExitFullscreenMode();
 }
 
 void WebContentsImpl::ResumeLoadingCreatedWebContents() {
+  if (delayed_open_url_params_.get()) {
+    OpenURL(*delayed_open_url_params_.get());
+    delayed_open_url_params_.reset(nullptr);
+    return;

[nasko, 2015/07/10 07:42:20]

Why is there a return here? Skipping the initialization of RVH and RFH doesn't
seem like a good idea. It will very likely break window.open() cases if this
delayed path is hit.

[Maria, 2015/07/10 16:26:25]

This function is not called in the initialization path for new window load with
opener_suppressed usually. Usually we synchronously start OpenURL on web
contents in that path. However, on Android we have to finish setting up our
tab/web contents delegate asynchronously before we start the page load. 

We already have code that calls into ResumeLoadingCreatedWebContents() from Java
when such setup is completed (for window.open() cases). I added this here
because we would use the same signal to complete the load in opener_suppressed
case, but returning early because I believe we wouldn't have usually initialized
RVH/RFH through here.

+  }
+
   // Resume blocked requests for both the RenderViewHost and RenderFrameHost.
   // TODO(brettw): It seems bogus to reach into here and initialize the host.
   GetRenderViewHost()->Init();
   GetMainFrame()->Init();
 }
 
 bool WebContentsImpl::FocusLocationBarByDefault() {
   NavigationEntry* entry = controller_.GetVisibleEntry();
   if (entry && entry->GetURL() == GURL(url::kAboutBlankURL))
     return true;
@@ skipping 1809 matching lines @@
   player_map->erase(it);
 }
 
 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
   force_disable_overscroll_content_ = force_disable;
   if (view_)
     view_->SetOverscrollControllerEnabled(CanOverscrollContent());
 }
 
 }  // namespace content