Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1233413003: Version 4.4.63.20 (cherry-pick) (Closed)

Created:
5 years, 5 months ago by Michael Hablich
Modified:
5 years, 5 months ago
CC:
v8-dev, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.4
Target Ref:
refs/pending/branch-heads/4.4
Project:
v8
Visibility:
Public.

Description

Version 4.4.63.20 (cherry-pick) Merged 6802c4b921fdc717227fec996e6988ff12a93c1b Merged d05538827e32ebfed5297653266d65c11e438148 Merged 879550ce0f8d3cffb519440101a4026635bc6026 Merged 3c9c7748c386d967762116de53e31dd1d24f8627 [arm] Remove unused jump_elimination_allowed parameter to Assembler::branch_offset(). [arm] Fix missing CheckBuffer for branches. [arm] Don't call branch_offset within CheckConstPool. [arm] CheckConstPool between TurboFan instructions. Conflicts resolved by manual patch BUG=v8:4292, chromium:509666 LOG=N R=bmeurer@chromium.org, jacob.bramley@arm.com Committed: https://chromium.googlesource.com/v8/v8/+/15508c765bf761b7eee990c46f41446f0c241db2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -21 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/assembler-arm.h View 3 chunks +13 lines, -8 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +20 lines, -9 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Michael Hablich
5 years, 5 months ago (2015-07-17 09:30:13 UTC) #1
Benedikt Meurer
lgtm
5 years, 5 months ago (2015-07-17 09:37:06 UTC) #2
Michael Hablich
Committed patchset #1 (id:1) manually as 15508c765bf761b7eee990c46f41446f0c241db2.
5 years, 5 months ago (2015-07-17 09:41:06 UTC) #3
Michael Hablich
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1238973009/ by hablich@chromium.org. ...
5 years, 5 months ago (2015-07-17 13:55:06 UTC) #4
jbramley
On 2015/07/17 13:55:06, Hablich wrote: > Jacob, can you have a look please? It seems ...
5 years, 5 months ago (2015-07-17 14:20:39 UTC) #5
jbramley
5 years, 5 months ago (2015-07-17 16:14:48 UTC) #6
Message was sent while issue was closed.
On 2015/07/17 13:55:06, Hablich wrote:
> Jacob, can you have a look please? It seems a merge back to 4.4 is not that
> straight-forward..

See https://codereview.chromium.org/1227403006/

It makes sense on master and, if cherry-picked onto 4.4.63.20 it passes
arm.optdebug.check.

Powered by Google App Engine
This is Rietveld 408576698