Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.h

Issue 12334104: Merge 143454 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.h
===================================================================
--- Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.h (revision 144107)
+++ Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.h (working copy)
@@ -75,6 +75,7 @@
return 0;
}
+ clearContextAndRoles();
ListItemType newItem = passNewItem;
return Base::initializeValues(newItem, ec);
}
@@ -93,18 +94,8 @@
return Base::insertItemBeforeValues(newItem, index, ec);
}
- PassListItemType replaceItem(PassListItemType passNewItem, unsigned index, ExceptionCode& ec)
- {
- // Not specified, but FF/Opera do it this way, and it's just sane.
- if (!passNewItem) {
- ec = SVGException::SVG_WRONG_TYPE_ERR;
- return 0;
- }
+ PassListItemType replaceItem(PassListItemType, unsigned index, ExceptionCode&);
- ListItemType newItem = passNewItem;
- return Base::replaceItemValues(newItem, index, ec);
- }
-
PassListItemType removeItem(unsigned index, ExceptionCode&);
PassListItemType appendItem(PassListItemType passNewItem, ExceptionCode& ec)
@@ -129,6 +120,8 @@
SVGPathElement* contextElement() const;
+ void clearContextAndRoles();
+
using Base::m_role;
virtual bool isReadOnly() const
« no previous file with comments | « LayoutTests/svg/dom/SVGPathSegList-crash-expected.txt ('k') | Source/WebCore/svg/properties/SVGPathSegListPropertyTearOff.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698