Issue 12334099: IndexedDB: Re-enable key-type-array test as FLAKY to check current behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12334099: IndexedDB: Re-enable key-type-array test as FLAKY to check current behavior (Closed)

Created:
7 years, 10 months ago by jsbell

Modified:
7 years, 9 months ago

Reviewers:
dgrogan

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, haraken

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

IndexedDB: Re-enable key-type-array test as FLAKY to check current behavior This test started failing flakily several months ago; the root cause was not identified but appeared to be a difficult to repro v8/binding/gc issue. Unable to repro locally but some extensive work has been done in this area recently, so we want to enable the test to see if it's still flaking. BUG=165671 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184766

Patch Set 1 #

Total comments: 1

Patch Set 2 : Just use RunLayoutTest #

Patch Set 3 : Just use RunLayoutTest #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	content/browser/in_process_webkit/indexed_db_layout_browsertest.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jsbell

And for reference: yes, we do still use FLAKY, but only for debugging like this: ...

7 years, 10 months ago (2013-02-26 21:11:24 UTC) #2

dgrogan

lgtm https://codereview.chromium.org/12334099/diff/1/content/browser/in_process_webkit/indexed_db_layout_browsertest.cc File content/browser/in_process_webkit/indexed_db_layout_browsertest.cc (right): https://codereview.chromium.org/12334099/diff/1/content/browser/in_process_webkit/indexed_db_layout_browsertest.cc#newcode158 content/browser/in_process_webkit/indexed_db_layout_browsertest.cc:158: RunLayoutTests(kFlakyTests); FYI, you could do away with kFlakyTests ...

7 years, 10 months ago (2013-02-26 21:14:36 UTC) #3

jsbell

7 years, 9 months ago (2013-02-26 23:26:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r184766 (presubmit successful).

Expand Messages | Collapse Messages