Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7206)

Unified Diff: chrome/browser/storage_monitor/storage_monitor_chromeos.cc

Issue 12334096: Regularize ownerships and lifecycle for storage monitor platform classes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Remove windows pending VolumeMountWatcher pool management Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/storage_monitor/storage_monitor_chromeos.cc
diff --git a/chrome/browser/storage_monitor/storage_monitor_chromeos.cc b/chrome/browser/storage_monitor/storage_monitor_chromeos.cc
index 44dcf949ac5d9b9e3ca6e9f7ab07a830361bf45c..0f2bae5004fa4b0df65d511f000e4d4ceb26a358 100644
--- a/chrome/browser/storage_monitor/storage_monitor_chromeos.cc
+++ b/chrome/browser/storage_monitor/storage_monitor_chromeos.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/storage_monitor/storage_monitor_chromeos.h"
+#include "base/command_line.h"
#include "base/files/file_path.h"
#include "base/logging.h"
#include "base/stl_util.h"
@@ -14,8 +15,11 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/storage_monitor/media_device_notifications_utils.h"
#include "chrome/browser/storage_monitor/media_storage_util.h"
+#include "chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.h"
#include "chrome/browser/storage_monitor/removable_device_constants.h"
+#include "chrome/common/chrome_switches.h"
#include "content/public/browser/browser_thread.h"
+#include "device/media_transfer_protocol/media_transfer_protocol_manager.h"
namespace chromeos {
@@ -103,18 +107,34 @@ bool GetDeviceInfo(const std::string& source_path,
using content::BrowserThread;
StorageMonitorCros::StorageMonitorCros() {
- DCHECK(disks::DiskMountManager::GetInstance());
- disks::DiskMountManager::GetInstance()->AddObserver(this);
- CheckExistingMountPointsOnUIThread();
}
StorageMonitorCros::~StorageMonitorCros() {
+ if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType)) {
+ device::MediaTransferProtocolManager::Shutdown();
+ }
+
disks::DiskMountManager* manager = disks::DiskMountManager::GetInstance();
if (manager) {
manager->RemoveObserver(this);
}
}
+void StorageMonitorCros::Init() {
+ DCHECK(disks::DiskMountManager::GetInstance());
+ disks::DiskMountManager::GetInstance()->AddObserver(this);
+ CheckExistingMountPointsOnUIThread();
+
+ if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kTestType)) {
+ scoped_refptr<base::MessageLoopProxy> loop_proxy;
+ device::MediaTransferProtocolManager::Initialize(loop_proxy);
+
+ media_transfer_protocol_device_observer_.reset(
+ new chrome::MediaTransferProtocolDeviceObserverLinux());
+ media_transfer_protocol_device_observer_->SetNotifications(receiver());
+ }
+}
+
void StorageMonitorCros::CheckExistingMountPointsOnUIThread() {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
const disks::DiskMountManager::MountPointMap& mount_point_map =

Powered by Google App Engine
This is Rietveld 408576698