chrome/browser/storage_monitor/storage_monitor.h - Issue 12334096: Regularize ownerships and lifecycle for storage monitor platform classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/storage_monitor/storage_monitor.h

Issue 12334096: Regularize ownerships and lifecycle for storage monitor platform classes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Document lifecycle in storage_monitor.h Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/storage_monitor/removable_device_notifications_linux.cc ('K') | « chrome/browser/storage_monitor/removable_device_notifications_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/storage_monitor/storage_monitor.h

diff --git a/chrome/browser/storage_monitor/storage_monitor.h b/chrome/browser/storage_monitor/storage_monitor.h

index 86ef72c17441fd4b541d3f2324373f60f3924d63..17e578285de1453afb2f311c594c944e195f4c59 100644

--- a/chrome/browser/storage_monitor/storage_monitor.h

+++ b/chrome/browser/storage_monitor/storage_monitor.h

@@ -24,6 +24,11 @@ class TransientDeviceIds;

// Base class for platform-specific instances watching for removable storage

// attachments/detachments.

+// Lifecycle contracts: This class is created by ChromeBrowserMain

+// implementations before the profile is initialized, so listeners can be

+// created during profile construction. The platform-specific initialization,

+// which can lead to calling registered listeners with notifications of

+// attached volumes, will happen after profile construction.

class StorageMonitor {

public:

struct StorageInfo {