chrome/browser/chrome_browser_main_win.h - Issue 12334096: Regularize ownerships and lifecycle for storage monitor platform classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main_win.h

Issue 12334096: Regularize ownerships and lifecycle for storage monitor platform classes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Document lifecycle in storage_monitor.h Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_browser_main_mac.mm ('K') | « chrome/browser/chrome_browser_main_mac.mm ('k') | chrome/browser/chrome_browser_main_win.cc » ('j') | chrome/browser/storage_monitor/removable_device_notifications_chromeos.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_browser_main_win.h

diff --git a/chrome/browser/chrome_browser_main_win.h b/chrome/browser/chrome_browser_main_win.h

index 7ea8b342d838eba2e2c3b63427d3f04f80dbf5b2..9915a48e862d50804b3fb5b67ac6c1984354b296 100644

--- a/chrome/browser/chrome_browser_main_win.h

+++ b/chrome/browser/chrome_browser_main_win.h

@@ -33,7 +33,8 @@ class ChromeBrowserMainPartsWin : public ChromeBrowserMainParts {

virtual void ToolkitInitialized() OVERRIDE;

virtual void PreMainMessageLoopStart() OVERRIDE;

virtual void PostMainMessageLoopStart() OVERRIDE;

- virtual void PreMainMessageLoopRun() OVERRIDE;

+ virtual void PreProfileInit() OVERRIDE;

+ virtual void PostProfileInit() OVERRIDE;

// ChromeBrowserMainParts overrides.

virtual void ShowMissingLocaleMessageBox() OVERRIDE;

@@ -69,6 +70,7 @@ class ChromeBrowserMainPartsWin : public ChromeBrowserMainParts {

private:

scoped_ptr<chrome::RemovableDeviceNotificationsWindowWin>

removable_device_notifications_window_;

DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainPartsWin);

};