chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc - Issue 12334096: Regularize ownerships and lifecycle for storage monitor platform classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc

Issue 12334096: Regularize ownerships and lifecycle for storage monitor platform classes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: in progress... changed to not require mtp manager in linux for tests. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chrome_browser_main_linux.h ('K') | « chrome/browser/chrome_browser_main_mac.mm ('k') | chrome/browser/storage_monitor/removable_device_notifications_chromeos.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc

diff --git a/chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc b/chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc

index f8cbc09bf4d1755490ed4b1b2973c1954dcc1a2a..479fc6a318b58787b2b6254f698bba2f0fc7e0ba 100644

--- a/chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc

+++ b/chrome/browser/storage_monitor/media_transfer_protocol_device_observer_linux.cc

@@ -128,8 +128,11 @@ MediaTransferProtocolDeviceObserverLinux()

device::MediaTransferProtocolManager* mtp_manager =

device::MediaTransferProtocolManager::GetInstance();

- mtp_manager->AddObserver(this);

- EnumerateStorages();

+ // May be null in unit tests.

+ if (mtp_manager) {

Lei Zhang 2013/02/28 02:14:43 As is, |mtp_manager| is always true here, because

Greg Billock 2013/02/28 22:35:37 That sounds like a great option. I'll add that to

+ mtp_manager->AddObserver(this);

+ EnumerateStorages();

+ }

}

// This constructor is only used by unit tests.