sdk/lib/_internal/compiler/implementation/ssa/optimize.dart - Issue 12334070: Support runtime check of function types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

Issue 12334070: Support runtime check of function types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Handle function types in checked mode. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

diff --git a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

index ffcab4d5e98b50d05897c134d93600931efd57a9..397071f86754a698c703fa15e4e7c07058143fec 100644

--- a/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

+++ b/sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

@@ -606,6 +606,10 @@ class SsaConstantFolder extends HBaseVisitor implements OptimizationPhase {

if (type != null && (!type.isRaw || type.kind == TypeKind.TYPE_VARIABLE)) {

return node;

}

+ if (type != null && type.kind == TypeKind.FUNCTION) {

+ // TODO(johnniwinther): Optimize function type conversions.

+ return node;

+ }

HType convertedType = node.instructionType;

if (convertedType.isUnknown()) return node;

HType combinedType = value.instructionType.intersection(