Support runtime check of function types.

sdk/lib/_internal/compiler/implementation/closure.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library closureToClassMapper;
 
 import "elements/elements.dart";
 import "dart2jslib.dart";
 import "dart_types.dart";
 import "scanner/scannerlib.dart" show Token;
@@ skipping 414 matching lines @@
       ClosureClassMap cached = closureMappingCache[function];
       if (!cached.parametersWithSentinel.containsKey(parameter)) {
         SourceString parameterName = parameter.name;
         String name = '${parameterName.slowToString()}_check';
         Element newElement = new CheckVariableElement(new SourceString(name),
                                                       parameter,
                                                       enclosing);
         useLocal(newElement);
         cached.parametersWithSentinel[parameter] = newElement;
       }
+    } else if (node.isOperator) {
+      String operatorString = node.selector.asOperator().source.stringValue;
+      if (operatorString == 'is' || operatorString == 'as') {

[karlklose, 2013/03/22 13:17:46]

I would really like to encapsulate this pattern. I think we have it in multiple
places now.

[Johnni Winther, 2013/06/12 14:39:10]

I looked. They are all slightly different.

+        DartType type = elements.getType(node.arguments.head);
+        analyzeType(type);
+      }
     }
     node.visitChildren(this);
   }
 
   visitSendSet(SendSet node) {
     Element element = elements[node];
     if (Elements.isLocal(element)) {
       mutatedVariables.add(element);
     }
     super.visitSendSet(node);
   }
 
   visitNewExpression(NewExpression node) {
     DartType type = elements.getType(node);
+    analyzeType(type);
+    node.visitChildren(this);
+  }
 
-    bool hasTypeVariable(DartType type) {
-      if (type is TypeVariableType) {
-        return true;
-      } else if (type is InterfaceType) {
-        InterfaceType ifcType = type;
-        for (DartType argument in ifcType.typeArguments) {
-          if (hasTypeVariable(argument)) {
-            return true;
-          }
-        }
+  void analyzeTypeVariables(DartType type) {
+    if (type is TypeVariableType) {
+      useLocal(type.element);
+    } else if (type is InterfaceType) {
+      InterfaceType ifcType = type;
+      for (DartType argument in ifcType.typeArguments) {
+        analyzeTypeVariables(argument);
       }
-      return false;
     }
+  }
 
-    void analyzeTypeVariables(DartType type) {
-      if (type is TypeVariableType) {
-        useLocal(type.element);
-      } else if (type is InterfaceType) {
-        InterfaceType ifcType = type;
-        for (DartType argument in ifcType.typeArguments) {
-          analyzeTypeVariables(argument);
+  void analyzeType(DartType type) {
+    if (type == null) return;

[karlklose, 2013/03/22 13:17:46]

How can this happen?

[Johnni Winther, 2013/06/21 12:19:14]

Bad handling of is!
Now fixed.

+    if (outermostElement.isMember() &&
+        compiler.backend.needsRti(outermostElement.getEnclosingClass())) {
+      if (outermostElement.isConstructor() ||
+          outermostElement.isField()) {
+        analyzeTypeVariables(type);
+      } else if (outermostElement.isInstanceMember()) {
+        if (type.containsTypeVariables) {
+          useLocal(closureData.thisElement);
         }
       }
     }
-
-    if (outermostElement.isMember() &&
-        compiler.backend.needsRti(outermostElement.getEnclosingClass())) {
-      if (outermostElement.isConstructor() || outermostElement.isField()) {
-        analyzeTypeVariables(type);
-      } else if (outermostElement.isInstanceMember()) {
-        if (hasTypeVariable(type)) useLocal(closureData.thisElement);
-      }
-    }
-
-    node.visitChildren(this);
   }
 
   // If variables that are declared in the [node] scope are captured and need
   // to be boxed create a box-element and update the [capturingScopes] in the
   // current [closureData].
   // The boxed variables are updated in the [capturedVariableMapping].
   void attachCapturedScopeVariables(Node node) {
     Element box = null;
     Map<Element, Element> scopeMapping = new Map<Element, Element>();
     for (Element element in scopeVariables) {
@@ skipping 144 matching lines @@
       if (currentElement.isFactoryConstructor() &&
           compiler.backend.needsRti(currentElement.enclosingElement)) {
         // Declare the type parameters in the scope. Generative
         // constructors just use 'this'.
         ClassElement cls = currentElement.enclosingElement;
         cls.typeVariables.forEach((TypeVariableType typeVariable) {
           declareLocal(typeVariable.element);
         });
       }
 
+      // Ensure that closure that need runtime type information has access to
+      // this of the enclosing class.
+      if (closureData.thisElement != null &&
+          compiler.backend.methodNeedsRti(element)) {
+        useLocal(closureData.thisElement);
+      }
+
       visitChildren();
     });
 
 
     ClosureClassMap savedClosureData = closureData;
     bool savedInsideClosure = insideClosure;
 
     // Restore old values.
     insideClosure = oldInsideClosure;
     closureData = oldClosureData;
@@ skipping 37 matching lines @@
   }
 
   visitTryStatement(TryStatement node) {
     // TODO(ngeoffray): implement finer grain state.
     bool oldInTryStatement = inTryStatement;
     inTryStatement = true;
     node.visitChildren(this);
     inTryStatement = oldInTryStatement;
   }
 }