Support runtime check of function types.

sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 abstract class HVisitor<R> {
   R visitAdd(HAdd node);
   R visitBailoutTarget(HBailoutTarget node);
   R visitBitAnd(HBitAnd node);
@@ skipping 1092 matching lines @@
     HInstruction current = this.next;
     while (current != null) {
       if (current == other) return true;
       current = current.next;
     }
     return false;
   }
 
   HInstruction convertType(Compiler compiler, DartType type, int kind) {
     if (type == null) return this;
+    type = type.unalias(compiler);
     // Only the builder knows how to create [HTypeConversion]
     // instructions with generics. It has the generic type context
     // available.
     assert(type.kind != TypeKind.TYPE_VARIABLE);
     // TODO(5022): Generic typedefs should not be handled here.

[karlklose, 2013/06/20 07:32:55]

This TODO is obsolete now.

[Johnni Winther, 2013/06/21 12:19:15]

Removed.

     assert(type.isRaw
            || type.isMalformed
-           || type.kind == TypeKind.TYPEDEF
            || type.kind == TypeKind.FUNCTION);
     if (identical(type.element, compiler.dynamicClass)) return this;
     if (identical(type.element, compiler.objectClass)) return this;
     if (type.isMalformed || type.kind != TypeKind.INTERFACE) {
       return new HTypeConversion(type, kind, HType.UNKNOWN, this);
     } else if (kind == HTypeConversion.BOOLEAN_CONVERSION_CHECK) {
       // Boolean conversion checks work on non-nullable booleans.
       return new HTypeConversion(type, kind, HType.BOOLEAN, this);
     } else if (kind == HTypeConversion.CHECKED_MODE_CHECK && !type.isRaw) {
         throw 'creating compound check to $type (this = ${this})';
@@ skipping 1113 matching lines @@
     return typeExpression == other.typeExpression
         && nullOk == other.nullOk
         && kind == other.kind;
   }
 }
 
 class HTypeConversion extends HCheck {
   final DartType typeExpression;
   final int kind;
   final Selector receiverTypeCheckSelector;
+  final bool contextIsTypeArguments;
 
   static const int NO_CHECK = 0;
   static const int CHECKED_MODE_CHECK = 1;
   static const int ARGUMENT_TYPE_CHECK = 2;
   static const int CAST_TYPE_CHECK = 3;
   static const int BOOLEAN_CONVERSION_CHECK = 4;
   static const int RECEIVER_TYPE_CHECK = 5;
 
   HTypeConversion(this.typeExpression, this.kind,
                   HType type, HInstruction input,
                   [this.receiverTypeCheckSelector])
-      : super(<HInstruction>[input]) {
+      : contextIsTypeArguments = false,
+        super(<HInstruction>[input]) {
     assert(!isReceiverTypeCheck || receiverTypeCheckSelector != null);
+    assert(typeExpression == null ||
+           typeExpression.kind != TypeKind.TYPEDEF);
     sourceElement = input.sourceElement;
     instructionType = type;
   }
 
   HTypeConversion.withTypeRepresentation(this.typeExpression, this.kind,
                                          HType type, HInstruction input,
                                          HInstruction typeRepresentation)
-      : super(<HInstruction>[input, typeRepresentation]),
+      : contextIsTypeArguments = false,
+        super(<HInstruction>[input, typeRepresentation]),
         receiverTypeCheckSelector = null {
+    assert(typeExpression.kind != TypeKind.TYPEDEF);
     sourceElement = input.sourceElement;
     instructionType = type;
   }
+
+  HTypeConversion.withContext(this.typeExpression, this.kind,
+                              HType type, HInstruction input,
+                              HInstruction context,
+                              {bool this.contextIsTypeArguments})
+      : super(<HInstruction>[input, context]),
+        receiverTypeCheckSelector = null {
+    assert(typeExpression.kind != TypeKind.TYPEDEF);
+    sourceElement = input.sourceElement;
+    instructionType = type;
+  }
 
   bool get hasTypeRepresentation => inputs.length > 1;
   HInstruction get typeRepresentation => inputs[1];
 
+  bool get hasContext => inputs.length > 1;

[karlklose, 2013/06/20 07:32:55]

So we distinguish an HIs withTypeRepresentation from on withContext by
type.kind? Perhaps the predicates hasTypeRepresentation and hasContext should
include that check.  Otherwise we could just have one getter called something
like hasAdditionalData.

[Johnni Winther, 2013/06/21 12:19:15]

Done.

+  HInstruction get context => inputs[1];
+
   HInstruction convertType(Compiler compiler, DartType type, int kind) {
     if (typeExpression == type) return this;
     return super.convertType(compiler, type, kind);
   }
 
   bool get isChecked => kind != NO_CHECK;
   bool get isCheckedModeCheck {
     return kind == CHECKED_MODE_CHECK
         || kind == BOOLEAN_CONVERSION_CHECK;
   }
@@ skipping 396 matching lines @@
   HBasicBlock get start => expression.start;
   HBasicBlock get end {
     // We don't create a switch block if there are no cases.
     assert(!statements.isEmpty);
     return statements.last.end;
   }
 
   bool accept(HStatementInformationVisitor visitor) =>
       visitor.visitSwitchInfo(this);
 }