runtime/bin/socket_patch.dart - Issue 12334035: Don't send null data events on a Socket stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket_patch.dart

Issue 12334035: Don't send null data events on a Socket stream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/socket_patch.dart

diff --git a/runtime/bin/socket_patch.dart b/runtime/bin/socket_patch.dart

index 6382fc70dbd0d7a75f21d105752bd15b80383170..15dd4c7773dca2dfed3c5d8f227254c092b1a91e 100644

--- a/runtime/bin/socket_patch.dart

+++ b/runtime/bin/socket_patch.dart

@@ -831,7 +831,8 @@ class _Socket extends Stream<List<int>> implements Socket {

void _onData(event) {

switch (event) {

case RawSocketEvent.READ:

- _controller.add(_raw.read());

+ var buffer = _raw.read();

+ if (buffer != null) _controller.add(buffer);

break;

case RawSocketEvent.WRITE:

_consumer.write();

« no previous file with comments | « no previous file | sdk/lib/io/secure_socket.dart » ('j') | no next file with comments »