Issue 1233393002: Conditionally disable bthledef.h workaround

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1233393002: Conditionally disable bthledef.h workaround (Closed)

Created:
5 years, 5 months ago by brucedawson

Modified:
5 years, 5 months ago

Reviewers:
rpaquay

CC:
chromium-reviews, scheib+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Conditionally disable bthledef.h workaround The bthledef.h header file is fixed in the Windows 10 SDK. This change detects when that SDK is being used and conditionally applies a fix. The conditional fix can be removed once we fully move to the Windows 10 SDK. The original workaround was checked in by cl https://codereview.chromium.org/720033003 R=rpaquay@chromium.org BUG=491424 Committed: https://crrev.com/80821ed5454c87b7b7387756d818ee4de8e4c15e Cr-Commit-Position: refs/heads/master@{#339160}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	device/bluetooth/bluetooth_low_energy_defs_win.h	View		2 chunks	+8 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233393002/1

5 years, 5 months ago (2015-07-16 23:08:30 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-16 23:18:40 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/80821ed5454c87b7b7387756d818ee4de8e4c15e
Cr-Commit-Position: refs/heads/master@{#339160}