Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 123333003: Use a pointer type for values in DocumentOrderedMap (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use a pointer type for values in DocumentOrderedMap Use a pointer type for values in DocumentOrderedMap (OwnPtr<MapEntry>) instead of a struct type (MapEntry). This should hopefully fix the performance regression on Bindings/get-element-by-id micro benchmark caused by r164029 on some platforms. While this CL seems to have no performance impact on Linux Desktop, I see a 14% improvement on Bindings/get-element-by-id micro benchmark on Android (tested on Galaxy Note 3 device). This may be due to HashTable optimizations when the empty value for ValueType is zero, or to better caching. R=esprehn, abarth BUG=330778 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -38 lines) Patch
M Source/core/dom/DocumentOrderedMap.h View 3 chunks +2 lines, -7 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 4 chunks +30 lines, -31 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-02 22:27:41 UTC) #1
abarth-chromium
LGTM It's usually better to store pointers in HashMaps because the HashMap's table is bloated ...
6 years, 11 months ago (2014-01-03 03:01:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/123333003/1
6 years, 11 months ago (2014-01-03 03:01:43 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-03 03:07:43 UTC) #4
Message was sent while issue was closed.
Change committed as 164440

Powered by Google App Engine
This is Rietveld 408576698