Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 1233323002: MIPS: Fix 'Reland Update V8 DEPS.' (Closed)

Created:
5 years, 5 months ago by balazs.kilvady
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'Reland Update V8 DEPS.' Port c63e50edc93f0f37b98008fe4012ec3c9479352b BUG= TEST=test-disasm-mips/Type Committed: https://crrev.com/bb247d4fb437b91acb984ccdabfeb4ffbfedb65a Cr-Commit-Position: refs/heads/master@{#29688}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M test/cctest/test-disasm-mips.cc View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
paul.l...
LGTM. Let's land it. Michael, what's the reason for adding these -32768 -> 65535U changes ...
5 years, 5 months ago (2015-07-15 18:30:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233323002/1
5 years, 5 months ago (2015-07-15 18:33:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 18:59:09 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 18:59:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb247d4fb437b91acb984ccdabfeb4ffbfedb65a
Cr-Commit-Position: refs/heads/master@{#29688}

Powered by Google App Engine
This is Rietveld 408576698