components/secure_display.gypi - Issue 1233313005: Move elide_url to its own component

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/secure_display.gypi

Issue 1233313005: Move elide_url to its own component (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add cast to fix windows bot Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 {

	6 'targets': [

	7 {

	8 # GN version: //components/secure_display

	9 'target_name': 'secure_display',

	10 'type': '<(component)',
	noyau (Ping after 24h) 2015/07/22 09:44:00 Most simple components are of type static_library, Most simple components are of type static_library, is this code really worth another DLL on Windows? sdefresne@, is there a doc somewhere explicitly explaining the pro and cons of components vs static libs in components/ ? Miguel Garcia 2015/07/22 12:33:06 I moved the gn file to be component as well to be Show quoted text On 2015/07/22 09:44:00, noyau wrote: > Most simple components are of type static_library, is this code really worth > another DLL on Windows? > > sdefresne@, is there a doc somewhere explicitly explaining the pro and cons of > components vs static libs in components/ ? I moved the gn file to be component as well to be consistent happy to change it (now or in a separate cl) if sdefresne has feedback. noyau (Ping after 24h) 2015/07/22 13:26:53 From Sylvain, himself quoting from brettw on chrom Show quoted text On 2015/07/22 12:33:06, Miguel Garcia wrote: > On 2015/07/22 09:44:00, noyau wrote: > > Most simple components are of type static_library, is this code really worth > > another DLL on Windows? > > > > sdefresne@, is there a doc somewhere explicitly explaining the pro and cons of > > components vs static libs in components/ ? > > I moved the gn file to be component as well to be consistent happy to change it > (now or in a separate cl) if sdefresne has feedback. From Sylvain, himself quoting from brettw on chromium-dev: Show quoted text > A component requires linking. A GN source set requires no linking. > > The only reason components are desirable in the first place is that some > bigger things can be linked together and not require a full rebuild of > chrome when one thing changes. > > IMO we already have too many components. A component should be typically > something on the level of a toplevel directory like net or base. > > So, my understanding is that code in //components should probably be just a > bunch of static_library/source_set. Please make this a static library.
	11 'dependencies': [

	12 '../base/base.gyp:base',

	13 '../net/net.gyp:net',

	14 '../url/url.gyp:url_lib',

	15 '../ui/gfx/gfx.gyp:gfx',

	16 ],

	17 'defines': [

	18 'SECURE_DISPLAY_IMPLEMENTATION',

	19 ],

	20 'sources': [

	21 # Note: file list duplicated in GN build.

	22 'secure_display/elide_url.h',

	23 'secure_display/elide_url.cc',

	24 'secure_display/secure_display_export.h',

	25 ]

	26 }

	27 ]

	28 }

	29

OLD	NEW

« no previous file with comments | « components/components_tests.gyp ('k') | components/secure_display/BUILD.gn » ('j') | components/secure_display/BUILD.gn » ('J')