Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2014 The Chromium Authors. All rights reserved. | 1 // Copyright 2014 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "chrome/browser/ui/elide_url.h" | 5 #include "components/secure_display/elide_url.h" |
| 6 | 6 |
| 7 #include "base/logging.h" | 7 #include "base/logging.h" |
| 8 #include "base/strings/string_split.h" | 8 #include "base/strings/string_split.h" |
| 9 #include "base/strings/utf_string_conversions.h" | 9 #include "base/strings/utf_string_conversions.h" |
| 10 #include "net/base/escape.h" | 10 #include "net/base/escape.h" |
| 11 #include "net/base/net_util.h" | 11 #include "net/base/net_util.h" |
| 12 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" | 12 #include "net/base/registry_controlled_domains/registry_controlled_domain.h" |
| 13 #include "ui/gfx/text_elider.h" | 13 #include "ui/gfx/text_elider.h" |
| 14 #include "ui/gfx/text_utils.h" | 14 #include "ui/gfx/text_utils.h" |
| 15 #include "url/gurl.h" | 15 #include "url/gurl.h" |
| 16 #include "url/url_constants.h" | 16 #include "url/url_constants.h" |
| 17 | 17 |
| 18 using base::UTF8ToUTF16; | 18 using base::UTF8ToUTF16; |
| 19 using gfx::ElideText; | 19 using gfx::ElideText; |
| 20 using gfx::GetStringWidthF; | 20 using gfx::GetStringWidthF; |
| 21 using gfx::kEllipsisUTF16; | 21 using gfx::kEllipsisUTF16; |
| 22 using gfx::kForwardSlash; | 22 using gfx::kForwardSlash; |
| 23 | 23 |
| 24 namespace { | 24 namespace { |
| 25 | 25 |
| 26 #if !defined(OS_ANDROID) | |
| 26 const base::char16 kDot = '.'; | 27 const base::char16 kDot = '.'; |
| 27 | 28 |
| 28 // Build a path from the first |num_components| elements in |path_elements|. | 29 // Build a path from the first |num_components| elements in |path_elements|. |
| 29 // Prepends |path_prefix|, appends |filename|, inserts ellipsis if appropriate. | 30 // Prepends |path_prefix|, appends |filename|, inserts ellipsis if appropriate. |
| 30 base::string16 BuildPathFromComponents( | 31 base::string16 BuildPathFromComponents( |
| 31 const base::string16& path_prefix, | 32 const base::string16& path_prefix, |
| 32 const std::vector<base::string16>& path_elements, | 33 const std::vector<base::string16>& path_elements, |
| 33 const base::string16& filename, | 34 const base::string16& filename, |
| 34 size_t num_components) { | 35 size_t num_components) { |
| 35 // Add the initial elements of the path. | 36 // Add the initial elements of the path. |
| (...skipping 18 matching lines...) Expand all Loading... | |
| 54 const base::string16& url_path_prefix, | 55 const base::string16& url_path_prefix, |
| 55 const std::vector<base::string16>& url_path_elements, | 56 const std::vector<base::string16>& url_path_elements, |
| 56 const base::string16& url_filename, | 57 const base::string16& url_filename, |
| 57 const base::string16& url_query, | 58 const base::string16& url_query, |
| 58 const gfx::FontList& font_list, | 59 const gfx::FontList& font_list, |
| 59 float available_pixel_width) { | 60 float available_pixel_width) { |
| 60 const size_t url_path_number_of_elements = url_path_elements.size(); | 61 const size_t url_path_number_of_elements = url_path_elements.size(); |
| 61 | 62 |
| 62 CHECK(url_path_number_of_elements); | 63 CHECK(url_path_number_of_elements); |
| 63 for (size_t i = url_path_number_of_elements - 1; i > 0; --i) { | 64 for (size_t i = url_path_number_of_elements - 1; i > 0; --i) { |
| 64 base::string16 elided_path = BuildPathFromComponents(url_path_prefix, | 65 base::string16 elided_path = BuildPathFromComponents( |
| 65 url_path_elements, url_filename, i); | 66 url_path_prefix, url_path_elements, url_filename, i); |
| 66 if (available_pixel_width >= GetStringWidthF(elided_path, font_list)) | 67 if (available_pixel_width >= GetStringWidthF(elided_path, font_list)) |
| 67 return ElideText(elided_path + url_query, font_list, | 68 return ElideText(elided_path + url_query, font_list, |
| 68 available_pixel_width, gfx::ELIDE_TAIL); | 69 available_pixel_width, gfx::ELIDE_TAIL); |
| 69 } | 70 } |
| 70 | 71 |
| 71 return base::string16(); | 72 return base::string16(); |
| 72 } | 73 } |
| 73 | 74 |
| 74 // Splits the hostname in the |url| into sub-strings for the full hostname, | 75 // Splits the hostname in the |url| into sub-strings for the full hostname, |
| 75 // the domain (TLD+1), and the subdomain (everything leading the domain). | 76 // the domain (TLD+1), and the subdomain (everything leading the domain). |
| 76 void SplitHost(const GURL& url, | 77 void SplitHost(const GURL& url, |
| 77 base::string16* url_host, | 78 base::string16* url_host, |
| 78 base::string16* url_domain, | 79 base::string16* url_domain, |
| 79 base::string16* url_subdomain) { | 80 base::string16* url_subdomain) { |
| 80 // Get Host. | 81 // Get Host. |
| 81 *url_host = UTF8ToUTF16(url.host()); | 82 *url_host = UTF8ToUTF16(url.host()); |
| 82 | 83 |
| 83 // Get domain and registry information from the URL. | 84 // Get domain and registry information from the URL. |
| 84 *url_domain = UTF8ToUTF16( | 85 *url_domain = |
| 85 net::registry_controlled_domains::GetDomainAndRegistry( | 86 UTF8ToUTF16(net::registry_controlled_domains::GetDomainAndRegistry( |
| 86 url, net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES)); | 87 url, net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES)); |
| 87 if (url_domain->empty()) | 88 if (url_domain->empty()) |
| 88 *url_domain = *url_host; | 89 *url_domain = *url_host; |
| 89 | 90 |
| 90 // Add port if required. | 91 // Add port if required. |
| 91 if (!url.port().empty()) { | 92 if (!url.port().empty()) { |
| 92 *url_host += UTF8ToUTF16(":" + url.port()); | 93 *url_host += UTF8ToUTF16(":" + url.port()); |
| 93 *url_domain += UTF8ToUTF16(":" + url.port()); | 94 *url_domain += UTF8ToUTF16(":" + url.port()); |
| 94 } | 95 } |
| 95 | 96 |
| 96 // Get sub domain. | 97 // Get sub domain. |
| 97 const size_t domain_start_index = url_host->find(*url_domain); | 98 const size_t domain_start_index = url_host->find(*url_domain); |
| 98 base::string16 kWwwPrefix = UTF8ToUTF16("www."); | 99 base::string16 kWwwPrefix = UTF8ToUTF16("www."); |
| 99 if (domain_start_index != base::string16::npos) | 100 if (domain_start_index != base::string16::npos) |
| 100 *url_subdomain = url_host->substr(0, domain_start_index); | 101 *url_subdomain = url_host->substr(0, domain_start_index); |
| 101 if ((*url_subdomain == kWwwPrefix || url_subdomain->empty() || | 102 if ((*url_subdomain == kWwwPrefix || url_subdomain->empty() || |
| 102 url.SchemeIsFile())) { | 103 url.SchemeIsFile())) { |
| 103 url_subdomain->clear(); | 104 url_subdomain->clear(); |
| 104 } | 105 } |
| 105 } | 106 } |
| 106 | 107 |
| 108 #endif | |
|
noyau (Ping after 24h)
2015/07/22 09:44:00
nit
#endif // !defined(OS_ANDROID)
Miguel Garcia
2015/07/22 12:33:06
Done.
| |
| 107 } // namespace | 109 } // namespace |
| 108 | 110 |
| 111 namespace secure_display { | |
| 112 | |
| 113 #if !defined(OS_ANDROID) | |
| 114 | |
| 109 // TODO(pkasting): http://crbug.com/77883 This whole function gets | 115 // TODO(pkasting): http://crbug.com/77883 This whole function gets |
| 110 // kerning/ligatures/etc. issues potentially wrong by assuming that the width of | 116 // kerning/ligatures/etc. issues potentially wrong by assuming that the width of |
| 111 // a rendered string is always the sum of the widths of its substrings. Also I | 117 // a rendered string is always the sum of the widths of its substrings. Also I |
| 112 // suspect it could be made simpler. | 118 // suspect it could be made simpler. |
| 113 base::string16 ElideUrl(const GURL& url, | 119 base::string16 ElideUrl(const GURL& url, |
| 114 const gfx::FontList& font_list, | 120 const gfx::FontList& font_list, |
| 115 float available_pixel_width, | 121 float available_pixel_width, |
| 116 const std::string& languages) { | 122 const std::string& languages) { |
| 117 // Get a formatted string and corresponding parsing of the url. | 123 // Get a formatted string and corresponding parsing of the url. |
| 118 url::Parsed parsed; | 124 url::Parsed parsed; |
| (...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 164 url_subdomain.clear(); | 170 url_subdomain.clear(); |
| 165 | 171 |
| 166 const base::string16 kColon = UTF8ToUTF16(":"); | 172 const base::string16 kColon = UTF8ToUTF16(":"); |
| 167 url_host = url_domain = file_path_split.at(0).substr(1) + kColon; | 173 url_host = url_domain = file_path_split.at(0).substr(1) + kColon; |
| 168 url_path_query_etc = url_path = file_path_split.at(1); | 174 url_path_query_etc = url_path = file_path_split.at(1); |
| 169 } | 175 } |
| 170 } | 176 } |
| 171 | 177 |
| 172 // Second Pass - remove scheme - the rest fits. | 178 // Second Pass - remove scheme - the rest fits. |
| 173 const float pixel_width_url_host = GetStringWidthF(url_host, font_list); | 179 const float pixel_width_url_host = GetStringWidthF(url_host, font_list); |
| 174 const float pixel_width_url_path = GetStringWidthF(url_path_query_etc, | 180 const float pixel_width_url_path = |
| 175 font_list); | 181 GetStringWidthF(url_path_query_etc, font_list); |
| 176 if (available_pixel_width >= | 182 if (available_pixel_width >= pixel_width_url_host + pixel_width_url_path) |
| 177 pixel_width_url_host + pixel_width_url_path) | |
| 178 return url_host + url_path_query_etc; | 183 return url_host + url_path_query_etc; |
| 179 | 184 |
| 180 // Third Pass: Subdomain, domain and entire path fits. | 185 // Third Pass: Subdomain, domain and entire path fits. |
| 181 const float pixel_width_url_domain = GetStringWidthF(url_domain, font_list); | 186 const float pixel_width_url_domain = GetStringWidthF(url_domain, font_list); |
| 182 const float pixel_width_url_subdomain = | 187 const float pixel_width_url_subdomain = |
| 183 GetStringWidthF(url_subdomain, font_list); | 188 GetStringWidthF(url_subdomain, font_list); |
| 184 if (available_pixel_width >= | 189 if (available_pixel_width >= |
| 185 pixel_width_url_subdomain + pixel_width_url_domain + | 190 pixel_width_url_subdomain + pixel_width_url_domain + pixel_width_url_path) |
| 186 pixel_width_url_path) | |
| 187 return url_subdomain + url_domain + url_path_query_etc; | 191 return url_subdomain + url_domain + url_path_query_etc; |
| 188 | 192 |
| 189 // Query element. | 193 // Query element. |
| 190 base::string16 url_query; | 194 base::string16 url_query; |
| 191 const float kPixelWidthDotsTrailer = GetStringWidthF( | 195 const float kPixelWidthDotsTrailer = |
| 192 base::string16(kEllipsisUTF16), font_list); | 196 GetStringWidthF(base::string16(kEllipsisUTF16), font_list); |
| 193 if (parsed.query.is_nonempty()) { | 197 if (parsed.query.is_nonempty()) { |
| 194 url_query = UTF8ToUTF16("?") + url_string.substr(parsed.query.begin); | 198 url_query = UTF8ToUTF16("?") + url_string.substr(parsed.query.begin); |
| 195 if (available_pixel_width >= | 199 if (available_pixel_width >= |
| 196 (pixel_width_url_subdomain + pixel_width_url_domain + | 200 (pixel_width_url_subdomain + pixel_width_url_domain + |
| 197 pixel_width_url_path - GetStringWidthF(url_query, font_list))) { | 201 pixel_width_url_path - GetStringWidthF(url_query, font_list))) { |
| 198 return ElideText(url_subdomain + url_domain + url_path_query_etc, | 202 return ElideText(url_subdomain + url_domain + url_path_query_etc, |
| 199 font_list, available_pixel_width, gfx::ELIDE_TAIL); | 203 font_list, available_pixel_width, gfx::ELIDE_TAIL); |
| 200 } | 204 } |
| 201 } | 205 } |
| 202 | 206 |
| 203 // Parse url_path using '/'. | 207 // Parse url_path using '/'. |
| 204 std::vector<base::string16> url_path_elements; | 208 std::vector<base::string16> url_path_elements; |
| 205 base::SplitString(url_path, kForwardSlash, &url_path_elements); | 209 base::SplitString(url_path, kForwardSlash, &url_path_elements); |
| 206 | 210 |
| 207 // Get filename - note that for a path ending with / | 211 // Get filename - note that for a path ending with / |
| 208 // such as www.google.com/intl/ads/, the file name is ads/. | 212 // such as www.google.com/intl/ads/, the file name is ads/. |
| 209 base::string16 url_filename( | 213 base::string16 url_filename( |
| 210 url_path_elements.empty() ? base::string16() : url_path_elements.back()); | 214 url_path_elements.empty() ? base::string16() : url_path_elements.back()); |
| 211 size_t url_path_number_of_elements = url_path_elements.size(); | 215 size_t url_path_number_of_elements = url_path_elements.size(); |
| 212 if (url_filename.empty() && (url_path_number_of_elements > 1)) { | 216 if (url_filename.empty() && (url_path_number_of_elements > 1)) { |
| 213 // Path ends with a '/'. | 217 // Path ends with a '/'. |
| 214 --url_path_number_of_elements; | 218 --url_path_number_of_elements; |
| 215 url_filename = url_path_elements[url_path_number_of_elements - 1] + | 219 url_filename = |
| 216 kForwardSlash; | 220 url_path_elements[url_path_number_of_elements - 1] + kForwardSlash; |
| 217 } | 221 } |
| 218 | 222 |
| 219 const size_t kMaxNumberOfUrlPathElementsAllowed = 1024; | 223 const size_t kMaxNumberOfUrlPathElementsAllowed = 1024; |
| 220 if (url_path_number_of_elements <= 1 || | 224 if (url_path_number_of_elements <= 1 || |
| 221 url_path_number_of_elements > kMaxNumberOfUrlPathElementsAllowed) { | 225 url_path_number_of_elements > kMaxNumberOfUrlPathElementsAllowed) { |
| 222 // No path to elide, or too long of a path (could overflow in loop below) | 226 // No path to elide, or too long of a path (could overflow in loop below) |
| 223 // Just elide this as a text string. | 227 // Just elide this as a text string. |
| 224 return ElideText(url_subdomain + url_domain + url_path_query_etc, font_list, | 228 return ElideText(url_subdomain + url_domain + url_path_query_etc, font_list, |
| 225 available_pixel_width, gfx::ELIDE_TAIL); | 229 available_pixel_width, gfx::ELIDE_TAIL); |
| 226 } | 230 } |
| 227 | 231 |
| 228 // Start eliding the path and replacing elements by ".../". | 232 // Start eliding the path and replacing elements by ".../". |
| 229 const base::string16 kEllipsisAndSlash = | 233 const base::string16 kEllipsisAndSlash = |
| 230 base::string16(kEllipsisUTF16) + kForwardSlash; | 234 base::string16(kEllipsisUTF16) + kForwardSlash; |
| 231 const float pixel_width_ellipsis_slash = | 235 const float pixel_width_ellipsis_slash = |
| 232 GetStringWidthF(kEllipsisAndSlash, font_list); | 236 GetStringWidthF(kEllipsisAndSlash, font_list); |
| 233 | 237 |
| 234 // Check with both subdomain and domain. | 238 // Check with both subdomain and domain. |
| 235 base::string16 elided_path = | 239 base::string16 elided_path = ElideComponentizedPath( |
| 236 ElideComponentizedPath(url_subdomain + url_domain, url_path_elements, | 240 url_subdomain + url_domain, url_path_elements, url_filename, url_query, |
| 237 url_filename, url_query, font_list, | 241 font_list, available_pixel_width); |
| 238 available_pixel_width); | |
| 239 if (!elided_path.empty()) | 242 if (!elided_path.empty()) |
| 240 return elided_path; | 243 return elided_path; |
| 241 | 244 |
| 242 // Check with only domain. | 245 // Check with only domain. |
| 243 // If a subdomain is present, add an ellipsis before domain. | 246 // If a subdomain is present, add an ellipsis before domain. |
| 244 // This is added only if the subdomain pixel width is larger than | 247 // This is added only if the subdomain pixel width is larger than |
| 245 // the pixel width of kEllipsis. Otherwise, subdomain remains, | 248 // the pixel width of kEllipsis. Otherwise, subdomain remains, |
| 246 // which means that this case has been resolved earlier. | 249 // which means that this case has been resolved earlier. |
| 247 base::string16 url_elided_domain = url_subdomain + url_domain; | 250 base::string16 url_elided_domain = url_subdomain + url_domain; |
| 248 if (pixel_width_url_subdomain > kPixelWidthDotsTrailer) { | 251 if (pixel_width_url_subdomain > kPixelWidthDotsTrailer) { |
| 249 if (!url_subdomain.empty()) | 252 if (!url_subdomain.empty()) |
| 250 url_elided_domain = kEllipsisAndSlash[0] + url_domain; | 253 url_elided_domain = kEllipsisAndSlash[0] + url_domain; |
| 251 else | 254 else |
| 252 url_elided_domain = url_domain; | 255 url_elided_domain = url_domain; |
| 253 | 256 |
| 254 elided_path = ElideComponentizedPath(url_elided_domain, url_path_elements, | 257 elided_path = ElideComponentizedPath(url_elided_domain, url_path_elements, |
| 255 url_filename, url_query, font_list, | 258 url_filename, url_query, font_list, |
| 256 available_pixel_width); | 259 available_pixel_width); |
| 257 | 260 |
| 258 if (!elided_path.empty()) | 261 if (!elided_path.empty()) |
| 259 return elided_path; | 262 return elided_path; |
| 260 } | 263 } |
| 261 | 264 |
| 262 // Return elided domain/.../filename anyway. | 265 // Return elided domain/.../filename anyway. |
| 263 base::string16 final_elided_url_string(url_elided_domain); | 266 base::string16 final_elided_url_string(url_elided_domain); |
| 264 const float url_elided_domain_width = GetStringWidthF(url_elided_domain, | 267 const float url_elided_domain_width = |
| 265 font_list); | 268 GetStringWidthF(url_elided_domain, font_list); |
| 266 | 269 |
| 267 // A hack to prevent trailing ".../...". | 270 // A hack to prevent trailing ".../...". |
| 268 if ((available_pixel_width - url_elided_domain_width) > | 271 if ((available_pixel_width - url_elided_domain_width) > |
| 269 pixel_width_ellipsis_slash + kPixelWidthDotsTrailer + | 272 pixel_width_ellipsis_slash + kPixelWidthDotsTrailer + |
| 270 GetStringWidthF(base::ASCIIToUTF16("UV"), font_list)) { | 273 GetStringWidthF(base::ASCIIToUTF16("UV"), font_list)) { |
| 271 final_elided_url_string += BuildPathFromComponents(base::string16(), | 274 final_elided_url_string += BuildPathFromComponents( |
| 272 url_path_elements, url_filename, 1); | 275 base::string16(), url_path_elements, url_filename, 1); |
| 273 } else { | 276 } else { |
| 274 final_elided_url_string += url_path; | 277 final_elided_url_string += url_path; |
| 275 } | 278 } |
| 276 | 279 |
| 277 return ElideText(final_elided_url_string, font_list, available_pixel_width, | 280 return ElideText(final_elided_url_string, font_list, available_pixel_width, |
| 278 gfx::ELIDE_TAIL); | 281 gfx::ELIDE_TAIL); |
| 279 } | 282 } |
| 280 | 283 |
| 281 base::string16 ElideHost(const GURL& url, | 284 base::string16 ElideHost(const GURL& url, |
| 282 const gfx::FontList& font_list, | 285 const gfx::FontList& font_list, |
| 283 float available_pixel_width) { | 286 float available_pixel_width) { |
| 284 base::string16 url_host; | 287 base::string16 url_host; |
| 285 base::string16 url_domain; | 288 base::string16 url_domain; |
| 286 base::string16 url_subdomain; | 289 base::string16 url_subdomain; |
| 287 SplitHost(url, &url_host, &url_domain, &url_subdomain); | 290 SplitHost(url, &url_host, &url_domain, &url_subdomain); |
| 288 | 291 |
| 289 const float pixel_width_url_host = GetStringWidthF(url_host, font_list); | 292 const float pixel_width_url_host = GetStringWidthF(url_host, font_list); |
| 290 if (available_pixel_width >= pixel_width_url_host) | 293 if (available_pixel_width >= pixel_width_url_host) |
| 291 return url_host; | 294 return url_host; |
| 292 | 295 |
| 293 if (url_subdomain.empty()) | 296 if (url_subdomain.empty()) |
| 294 return url_domain; | 297 return url_domain; |
| 295 | 298 |
| 296 const float pixel_width_url_domain = GetStringWidthF(url_domain, font_list); | 299 const float pixel_width_url_domain = GetStringWidthF(url_domain, font_list); |
| 297 float subdomain_width = available_pixel_width - pixel_width_url_domain; | 300 float subdomain_width = available_pixel_width - pixel_width_url_domain; |
| 298 if (subdomain_width <= 0) | 301 if (subdomain_width <= 0) |
| 299 return base::string16(kEllipsisUTF16) + kDot + url_domain; | 302 return base::string16(kEllipsisUTF16) + kDot + url_domain; |
| 300 | 303 |
| 301 const base::string16 elided_subdomain = ElideText( | 304 const base::string16 elided_subdomain = |
| 302 url_subdomain, font_list, subdomain_width, gfx::ELIDE_HEAD); | 305 ElideText(url_subdomain, font_list, subdomain_width, gfx::ELIDE_HEAD); |
| 303 return elided_subdomain + url_domain; | 306 return elided_subdomain + url_domain; |
| 304 } | 307 } |
| 305 | 308 |
| 309 #endif | |
| 310 | |
| 306 base::string16 FormatUrlForSecurityDisplay(const GURL& url, | 311 base::string16 FormatUrlForSecurityDisplay(const GURL& url, |
| 307 const std::string& languages) { | 312 const std::string& languages) { |
| 308 if (!url.is_valid() || url.is_empty() || !url.IsStandard()) | 313 if (!url.is_valid() || url.is_empty() || !url.IsStandard()) |
| 309 return net::FormatUrl(url, languages); | 314 return net::FormatUrl(url, languages); |
| 310 | 315 |
| 311 const base::string16 colon(base::ASCIIToUTF16(":")); | 316 const base::string16 colon(base::ASCIIToUTF16(":")); |
| 312 const base::string16 scheme_separator( | 317 const base::string16 scheme_separator( |
| 313 base::ASCIIToUTF16(url::kStandardSchemeSeparator)); | 318 base::ASCIIToUTF16(url::kStandardSchemeSeparator)); |
| 314 | 319 |
| 315 if (url.SchemeIsFile()) { | 320 if (url.SchemeIsFile()) { |
| (...skipping 21 matching lines...) Expand all Loading... | |
| 337 result += base::UTF8ToUTF16(host); | 342 result += base::UTF8ToUTF16(host); |
| 338 | 343 |
| 339 const int port = origin.IntPort(); | 344 const int port = origin.IntPort(); |
| 340 const int default_port = url::DefaultPortForScheme(origin.scheme().c_str(), | 345 const int default_port = url::DefaultPortForScheme(origin.scheme().c_str(), |
| 341 origin.scheme().length()); | 346 origin.scheme().length()); |
| 342 if (port != url::PORT_UNSPECIFIED && port != default_port) | 347 if (port != url::PORT_UNSPECIFIED && port != default_port) |
| 343 result += colon + base::UTF8ToUTF16(origin.port()); | 348 result += colon + base::UTF8ToUTF16(origin.port()); |
| 344 | 349 |
| 345 return result; | 350 return result; |
| 346 } | 351 } |
| 352 } // namespace | |
| OLD | NEW |