chrome/browser/extensions/api/tabs/tabs_constants.h - Issue 1233263002: Clean up error handling logic for extension tab muting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_constants.h

Issue 1233263002: Clean up error handling logic for extension tab muting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issues from #4. Also use tab_constants for error strings." Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_api.cc ('k') | chrome/browser/extensions/api/tabs/tabs_constants.cc » ('j') | chrome/browser/ui/tabs/tab_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_constants.h

diff --git a/chrome/browser/extensions/api/tabs/tabs_constants.h b/chrome/browser/extensions/api/tabs/tabs_constants.h

index 7fef665b6bd361fc17a908763ddac7251d71a849..29b88a2a4fc515fd1fd820c65b84a048fbe083b6 100644

--- a/chrome/browser/extensions/api/tabs/tabs_constants.h

+++ b/chrome/browser/extensions/api/tabs/tabs_constants.h

@@ -94,6 +94,9 @@ extern const char kSupportedInWindowsOnlyError[];

extern const char kInvalidWindowTypeError[];

extern const char kInvalidWindowStateError[];

extern const char kScreenshotsDisabled[];

+extern const char kCannotUpdateMuteDisabled[];

miu 2015/07/18 00:42:42 Good idea! Nice! :)

+extern const char kCannotUpdateMuteCaptured[];

+extern const char kCannotUpdateMuteRateLimited[];

extern const char kCannotDetermineLanguageOfUnloadedTab[];