chrome/browser/extensions/api/tabs/tabs_constants.cc - Issue 1233263002: Clean up error handling logic for extension tab muting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_constants.cc

Issue 1233263002: Clean up error handling logic for extension tab muting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix issues from #4. Also use tab_constants for error strings." Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/tabs/tabs_constants.h ('K') | « chrome/browser/extensions/api/tabs/tabs_constants.h ('k') | chrome/browser/ui/tabs/tab_utils.h » ('j') | chrome/browser/ui/tabs/tab_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tabs/tabs_constants.cc

diff --git a/chrome/browser/extensions/api/tabs/tabs_constants.cc b/chrome/browser/extensions/api/tabs/tabs_constants.cc

index c6a63abc713e96633b57076e7eae6d3ebb54f230..91abd0cc379a0d2eb2d9a74e8b3bbbf572cf45a8 100644

--- a/chrome/browser/extensions/api/tabs/tabs_constants.cc

+++ b/chrome/browser/extensions/api/tabs/tabs_constants.cc

@@ -99,7 +99,13 @@ const char kSupportedInWindowsOnlyError[] = "Supported in Windows only";

const char kInvalidWindowTypeError[] = "Invalid value for type";

const char kInvalidWindowStateError[] = "Invalid value for state";

const char kScreenshotsDisabled[] = "Taking screenshots has been disabled";

+const char kCannotUpdateMuteDisabled[] =

+ "Failed to update mute state for tab *, --* must be enabled";

+const char kCannotUpdateMuteCaptured[] =

+ "Cannot update mute state for tab *, tab has audio or video currently "

+ "being captured";

+const char kCannotUpdateMuteRateLimited[] =

+ "Rate limit exceeded when updating mute state for tab *.";

const char kCannotDetermineLanguageOfUnloadedTab[] =

"Cannot determine language: tab not loaded";