Clean up error handling logic for extension tab muting

chrome/browser/extensions/api/tabs/tabs_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_api.h"
 
 #include <algorithm>
 #include <limits>
 #include <vector>
 
@@ skipping 1223 matching lines @@
 
   if (params->update_properties.pinned.get()) {
     bool pinned = *params->update_properties.pinned;
     tab_strip->SetTabPinned(tab_index, pinned);
 
     // Update the tab index because it may move when being pinned.
     tab_index = tab_strip->GetIndexOfWebContents(contents);
   }
 
   if (params->update_properties.muted.get()) {
-    if (chrome::IsTabAudioMutingFeatureEnabled()) {
-      if (!chrome::CanToggleAudioMute(contents)) {
-        WriteToConsole(
-            content::CONSOLE_MESSAGE_LEVEL_WARNING,
-            base::StringPrintf(
-                "Cannot update mute state for tab %d, tab has audio or video "
-                "currently being captured",
-                tab_id));
-      } else {
-        chrome::SetTabAudioMuted(contents, *params->update_properties.muted,
-                                 extension()->id());
-      }
-    } else {
-      WriteToConsole(content::CONSOLE_MESSAGE_LEVEL_WARNING,
-                     base::StringPrintf(
-                         "Failed to update mute state, --%s must be enabled",
-                         switches::kEnableTabAudioMuting));
+    TabMutedResult tabMutedResult = chrome::SetTabAudioMuted(

[not at google - send to devlin, 2015/07/24 21:48:48]

tab_muted_result

+        contents, *params->update_properties.muted, extension()->id());
+
+    switch (tabMutedResult) {
+      case TAB_MUTED_RESULT_FAIL_NOT_ENABLED:
+        error_ = ErrorUtils::FormatErrorMessage(
+            keys::kCannotUpdateMuteDisabled, base::IntToString(tab_id),
+            switches::kEnableTabAudioMuting);
+        return false;
+      case TAB_MUTED_RESULT_FAIL_TABCAPTURE:
+        error_ = ErrorUtils::FormatErrorMessage(keys::kCannotUpdateMuteCaptured,
+                                                base::IntToString(tab_id));
+        return false;
+      case TAB_MUTED_RESULT_FAIL_RATE_LIMITED:
+        error_ = ErrorUtils::FormatErrorMessage(
+            keys::kCannotUpdateMuteRateLimited, base::IntToString(tab_id));
+        return false;
+      case TAB_MUTED_RESULT_SUCCESS:
+        break;
     }
   }
 
   if (params->update_properties.opener_tab_id.get()) {
     int opener_id = *params->update_properties.opener_tab_id;
 
     WebContents* opener_contents = NULL;
     if (!ExtensionTabUtil::GetTabById(opener_id,
                                       GetProfile(),
                                       include_incognito(),
@@ skipping 755 matching lines @@
   ZoomModeToZoomSettings(zoom_mode, &zoom_settings);
   zoom_settings.default_zoom_factor.reset(new double(
       content::ZoomLevelToZoomFactor(zoom_controller->GetDefaultZoomLevel())));
 
   results_ = api::tabs::GetZoomSettings::Results::Create(zoom_settings);
   SendResponse(true);
   return true;
 }
 
 }  // namespace extensions