Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 var testTabId_; | 5 var testTabId_; |
| 6 | 6 |
| 7 chrome.test.runTests([ | 7 chrome.test.runTests([ |
| 8 function setupWindow() { | 8 function setupWindow() { |
| 9 chrome.tabs.getCurrent(pass(function(tab) { | 9 chrome.tabs.getCurrent(pass(function(tab) { |
| 10 testTabId_ = tab.id; | 10 testTabId_ = tab.id; |
| (...skipping 12 matching lines...) Expand all Loading... | |
| 23 })); | 23 })); |
| 24 })); | 24 })); |
| 25 }, | 25 }, |
| 26 | 26 |
| 27 function makeMuted() { | 27 function makeMuted() { |
| 28 onUpdatedExpect("muted", true, {mutedCause: chrome.runtime.id}); | 28 onUpdatedExpect("muted", true, {mutedCause: chrome.runtime.id}); |
| 29 chrome.tabs.update(testTabId_, {muted: true}, pass()); | 29 chrome.tabs.update(testTabId_, {muted: true}, pass()); |
| 30 }, | 30 }, |
| 31 | 31 |
| 32 function testStaysMutedAfterChangingWindow() { | 32 function testStaysMutedAfterChangingWindow() { |
| 33 chrome.windows.create({}, pass(function(window) | 33 chrome.windows.create({}, pass(function(window) { |
| 34 { | |
| 35 chrome.tabs.move(testTabId_, {windowId: window.id, index: -1}, | 34 chrome.tabs.move(testTabId_, {windowId: window.id, index: -1}, |
| 36 pass(function(tab) { | 35 pass(function(tab) { |
| 37 assertEq(true, tab.muted); | 36 assertEq(true, tab.muted); |
| 38 })); | 37 })); |
| 39 })); | 38 })); |
| 40 }, | 39 }, |
| 41 | 40 |
| 42 function makeNotMuted() { | 41 function makeNotMuted() { |
| 43 onUpdatedExpect("muted", false, {mutedCause: chrome.runtime.id}); | 42 onUpdatedExpect("muted", false, {mutedCause: chrome.runtime.id}); |
| 44 chrome.tabs.update(testTabId_, {muted: false}, pass()); | 43 chrome.tabs.update(testTabId_, {muted: false}, pass()); |
| 44 }, | |
| 45 | |
| 46 function frequentRequestsRateLimited() { | |
| 47 chrome.tabs.update(testTabId_, {muted: true}, pass()); | |
|
miu
2015/07/16 00:28:26
Please add a comment at the top of this function t
| |
| 48 chrome.tabs.update(testTabId_, {muted: false}, function(tab) { | |
| 49 assertEq(true, tab.muted); // state not updated since rate limited | |
|
miu
2015/07/16 00:28:26
For completeness, consider adding:
assertTrue(!
| |
| 50 }); | |
| 45 } | 51 } |
| 46 ]); | 52 ]); |
| OLD | NEW |