Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1233253003: adding unit test for textblob cache / GrBatchAtlas (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

adding unit test for textblob cache / GrBatchAtlas BUG=skia: Committed: https://skia.googlesource.com/skia/+/e49109f3b599afa1f9fe85d241aa68e842a7264e

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -0 lines) Patch
A tests/TextBlobCacheTest.cpp View 1 1 chunk +123 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
joshualitt
ptal. Any other cases you think we might be interested in? Adding Ben for the ...
5 years, 5 months ago (2015-07-17 18:22:39 UTC) #2
bungeman-skia
https://codereview.chromium.org/1233253003/diff/1/tests/TextBlobCacheTest.cpp File tests/TextBlobCacheTest.cpp (right): https://codereview.chromium.org/1233253003/diff/1/tests/TextBlobCacheTest.cpp#newcode86 tests/TextBlobCacheTest.cpp:86: SkString sname; Doesn't look like you're using anything in ...
5 years, 5 months ago (2015-07-17 19:07:57 UTC) #3
bsalomon
maybe a comment somewhere indicating what this is testing. otherwise lgtm
5 years, 5 months ago (2015-07-17 19:12:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233253003/20001
5 years, 5 months ago (2015-07-17 19:40:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/e49109f3b599afa1f9fe85d241aa68e842a7264e
5 years, 5 months ago (2015-07-17 19:47:44 UTC) #8
bungeman-skia
5 years, 5 months ago (2015-07-17 19:49:10 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1233253003/diff/20001/tests/TextBlobCacheTest...
File tests/TextBlobCacheTest.cpp (right):

https://codereview.chromium.org/1233253003/diff/20001/tests/TextBlobCacheTest...
tests/TextBlobCacheTest.cpp:84: SkString familyName;
Doesn't look like you're using the family name here either.

https://codereview.chromium.org/1233253003/diff/20001/tests/TextBlobCacheTest...
tests/TextBlobCacheTest.cpp:88: SkFontStyle fs;
Still not using this? I don't see why you want to call set->getStyle at all?

Powered by Google App Engine
This is Rietveld 408576698