Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1233193002: Improve test coverage of unused scroll delta for cc scrolling. (Closed)

Created:
5 years, 5 months ago by tdresser
Modified:
5 years, 5 months ago
Reviewers:
Ian Vollick, reveman
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve test coverage of unused scroll delta for cc scrolling. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/7befa9cf85342a0409502ed2c05d7610afec7844 Cr-Commit-Position: refs/heads/master@{#339070}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +16 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
tdresser
PTAL I almost broke this in the process of trying to reland https://codereview.chromium.org/1223713004/.
5 years, 5 months ago (2015-07-14 17:35:44 UTC) #2
reveman
lgtm % rbyers@'s review who wrote the test
5 years, 5 months ago (2015-07-14 18:18:22 UTC) #4
tdresser
rbyers@ is out for a week and a half. reveman@ stated he'd like a second ...
5 years, 5 months ago (2015-07-14 18:22:38 UTC) #6
Ian Vollick
On 2015/07/14 18:22:38, tdresser wrote: > rbyers@ is out for a week and a half. ...
5 years, 5 months ago (2015-07-16 13:30:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233193002/1
5 years, 5 months ago (2015-07-16 13:31:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/71386)
5 years, 5 months ago (2015-07-16 15:21:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233193002/1
5 years, 5 months ago (2015-07-16 16:13:36 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-16 17:47:36 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 17:48:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7befa9cf85342a0409502ed2c05d7610afec7844
Cr-Commit-Position: refs/heads/master@{#339070}

Powered by Google App Engine
This is Rietveld 408576698