Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Unified Diff: public/web/WebMIDIPermissionRequest.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « public/platform/WebCrypto.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/web/WebMIDIPermissionRequest.h
diff --git a/public/web/WebMIDIPermissionRequest.h b/public/web/WebMIDIPermissionRequest.h
index 87cafd6919e1798dc3c1b17827430d25decd57da..791e1da62ad22a047095bf7dd37a41005f5ba5c1 100644
--- a/public/web/WebMIDIPermissionRequest.h
+++ b/public/web/WebMIDIPermissionRequest.h
@@ -32,6 +32,7 @@
#define WebMIDIPermissionRequest_h
#include "../platform/WebCommon.h"
+#include "../platform/WebPrivatePtr.h"
namespace blink {
@@ -46,7 +47,15 @@ class WebSecurityOrigin;
class WebMIDIPermissionRequest {
public:
BLINK_EXPORT WebMIDIPermissionRequest(const WebMIDIPermissionRequest& other)
- : m_initializer(other.m_initializer) { }
+ {
+ assign(other);
+ }
+
+ ~WebMIDIPermissionRequest()
+ {
+ reset();
+ }
+
BLINK_EXPORT WebSecurityOrigin securityOrigin() const;
BLINK_EXPORT void setIsAllowed(bool);
@@ -55,11 +64,14 @@ public:
#if BLINK_IMPLEMENTATION
explicit WebMIDIPermissionRequest(MIDIAccessInitializer*);
- MIDIAccessInitializer* midiAccessInitializer() const { return m_initializer; }
+ MIDIAccessInitializer* midiAccessInitializer() const { return m_private.get(); }
#endif
private:
- MIDIAccessInitializer* m_initializer;
+ BLINK_EXPORT void reset();
+ BLINK_EXPORT void assign(const WebMIDIPermissionRequest&);
+
+ WebPrivatePtr<MIDIAccessInitializer> m_private;
};
inline bool operator==(const WebMIDIPermissionRequest& a, const WebMIDIPermissionRequest& b)
« no previous file with comments | « public/platform/WebCrypto.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698