Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8979)

Unified Diff: Source/web/NotificationPermissionClientImpl.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/Handle.h ('k') | Source/web/StorageQuotaClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/NotificationPermissionClientImpl.cpp
diff --git a/Source/web/NotificationPermissionClientImpl.cpp b/Source/web/NotificationPermissionClientImpl.cpp
index 73339522bb5bddfbb8d6a5caa500a6f464b6db47..2881968e0ca62e0fc9806a1ed1fc04e4577ac140 100644
--- a/Source/web/NotificationPermissionClientImpl.cpp
+++ b/Source/web/NotificationPermissionClientImpl.cpp
@@ -21,7 +21,7 @@ namespace {
class WebNotificationPermissionCallbackImpl : public WebNotificationPermissionCallback {
public:
- WebNotificationPermissionCallbackImpl(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver, NotificationPermissionCallback* deprecatedCallback)
+ WebNotificationPermissionCallbackImpl(ScriptPromiseResolver* resolver, NotificationPermissionCallback* deprecatedCallback)
: m_resolver(resolver)
, m_deprecatedCallback(deprecatedCallback)
{
@@ -39,7 +39,7 @@ public:
}
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
Persistent<NotificationPermissionCallback> m_deprecatedCallback;
};
@@ -68,7 +68,7 @@ ScriptPromise NotificationPermissionClientImpl::requestPermission(ScriptState* s
Document* document = toDocument(context);
WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(document->frame());
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
webFrame->client()->requestNotificationPermission(WebSecurityOrigin(context->securityOrigin()), new WebNotificationPermissionCallbackImpl(resolver, deprecatedCallback));
« no previous file with comments | « Source/platform/heap/Handle.h ('k') | Source/web/StorageQuotaClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698