Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: Source/modules/vr/VRGetDevicesCallback.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/vr/NavigatorVRDevice.cpp ('k') | Source/modules/vr/VRGetDevicesCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/vr/VRGetDevicesCallback.h
diff --git a/Source/modules/vr/VRGetDevicesCallback.h b/Source/modules/vr/VRGetDevicesCallback.h
index f7857f2426e367288eab9ca744e424547b83fbe3..1a18adcc5d8daeb697966743f2944ae0e152e805 100644
--- a/Source/modules/vr/VRGetDevicesCallback.h
+++ b/Source/modules/vr/VRGetDevicesCallback.h
@@ -7,8 +7,6 @@
#include "platform/heap/Handle.h"
#include "public/platform/modules/vr/WebVRClient.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefPtr.h"
namespace blink {
@@ -18,14 +16,14 @@ class WebVRClient;
class VRGetDevicesCallback final : public WebVRGetDevicesCallback {
public:
- VRGetDevicesCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, VRHardwareUnitCollection*);
+ VRGetDevicesCallback(ScriptPromiseResolver*, VRHardwareUnitCollection*);
~VRGetDevicesCallback() override;
void onSuccess(WebVector<WebVRDevice>*) override;
void onError() override;
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
Persistent<VRHardwareUnitCollection> m_hardwareUnits;
};
« no previous file with comments | « Source/modules/vr/NavigatorVRDevice.cpp ('k') | Source/modules/vr/VRGetDevicesCallback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698