Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1731)

Unified Diff: Source/modules/push_messaging/PushPermissionStatusCallbacks.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushPermissionStatusCallbacks.h
diff --git a/Source/modules/push_messaging/PushPermissionStatusCallbacks.h b/Source/modules/push_messaging/PushPermissionStatusCallbacks.h
index 89cf867e25111dbcc2df2cf38280208efb4e38da..838d443c4e637a56fb2d5876ed899967cd2a0b89 100644
--- a/Source/modules/push_messaging/PushPermissionStatusCallbacks.h
+++ b/Source/modules/push_messaging/PushPermissionStatusCallbacks.h
@@ -9,8 +9,6 @@
#include "public/platform/modules/push_messaging/WebPushPermissionStatus.h"
#include "public/platform/modules/push_messaging/WebPushProvider.h"
#include "wtf/Noncopyable.h"
-#include "wtf/PassRefPtr.h"
-#include "wtf/RefPtr.h"
namespace WTF {
class String;
@@ -25,7 +23,7 @@ class PushPermissionStatusCallbacks final : public WebPushPermissionStatusCallba
WTF_MAKE_NONCOPYABLE(PushPermissionStatusCallbacks);
public:
- explicit PushPermissionStatusCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>);
+ explicit PushPermissionStatusCallbacks(ScriptPromiseResolver*);
~PushPermissionStatusCallbacks() override;
void onSuccess(WebPushPermissionStatus*) override;
@@ -35,7 +33,7 @@ public:
private:
static WTF::String permissionString(WebPushPermissionStatus);
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
};
} // namespace blink
« no previous file with comments | « Source/modules/push_messaging/PushManager.cpp ('k') | Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698