Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2324)

Unified Diff: Source/modules/presentation/PresentationRequest.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/permissions/Permissions.cpp ('k') | Source/modules/push_messaging/PushManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/presentation/PresentationRequest.cpp
diff --git a/Source/modules/presentation/PresentationRequest.cpp b/Source/modules/presentation/PresentationRequest.cpp
index 0b4bf091b03ab8548324f759c5d0a2eb17bf282c..19af64082ade0d18825c3d7bc300a6baa0d4eb36 100644
--- a/Source/modules/presentation/PresentationRequest.cpp
+++ b/Source/modules/presentation/PresentationRequest.cpp
@@ -68,7 +68,7 @@ bool PresentationRequest::hasPendingActivity() const
ScriptPromise PresentationRequest::start(ScriptState* scriptState)
{
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
WebPresentationClient* client = presentationClient(executionContext());
@@ -83,7 +83,7 @@ ScriptPromise PresentationRequest::start(ScriptState* scriptState)
ScriptPromise PresentationRequest::join(ScriptState* scriptState, const String& id)
{
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
WebPresentationClient* client = presentationClient(executionContext());
@@ -98,7 +98,7 @@ ScriptPromise PresentationRequest::join(ScriptState* scriptState, const String&
ScriptPromise PresentationRequest::getAvailability(ScriptState* scriptState)
{
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
WebPresentationClient* client = presentationClient(executionContext());
« no previous file with comments | « Source/modules/permissions/Permissions.cpp ('k') | Source/modules/push_messaging/PushManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698