Source/modules/permissions/PermissionCallback.h - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/permissions/PermissionCallback.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp ('k') | Source/modules/permissions/PermissionCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/permissions/PermissionCallback.h

diff --git a/Source/modules/permissions/PermissionCallback.h b/Source/modules/permissions/PermissionCallback.h

index 052f9bdeca3a42f8eb714a2d2baf800c31e02c11..a5d1daaf06e1f1cf655676843bac52111759b65e 100644

--- a/Source/modules/permissions/PermissionCallback.h

+++ b/Source/modules/permissions/PermissionCallback.h

@@ -10,8 +10,6 @@

#include "public/platform/modules/permissions/WebPermissionStatus.h"

#include "public/platform/modules/permissions/WebPermissionType.h"

#include "wtf/Noncopyable.h"

-#include "wtf/PassRefPtr.h"

-#include "wtf/RefPtr.h"

namespace blink {

@@ -24,14 +22,14 @@ class ScriptPromiseResolver;

class PermissionCallback final

: public WebCallbacks<WebPermissionStatus*, void> {

public:

- PermissionCallback(PassRefPtr<ScriptPromiseResolver>, WebPermissionType);

+ PermissionCallback(ScriptPromiseResolver*, WebPermissionType);

~PermissionCallback() override;

void onSuccess(WebPermissionStatus*) override;

void onError() override;

private:

- RefPtr<ScriptPromiseResolver> m_resolver;

+ Persistent<ScriptPromiseResolver> m_resolver;

WebPermissionType m_permissionType;

WTF_MAKE_NONCOPYABLE(PermissionCallback);