Source/modules/navigatorconnect/AcceptConnectionObserver.h - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/navigatorconnect/AcceptConnectionObserver.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/navigatorconnect/AcceptConnectionObserver.h

diff --git a/Source/modules/navigatorconnect/AcceptConnectionObserver.h b/Source/modules/navigatorconnect/AcceptConnectionObserver.h

index a92326705674f9aa56f55472899648cddb483679..e122108e0ce38125840cfc58338cab57b6cf672c 100644

--- a/Source/modules/navigatorconnect/AcceptConnectionObserver.h

+++ b/Source/modules/navigatorconnect/AcceptConnectionObserver.h

@@ -53,7 +53,7 @@ private:

Member<ServicePortCollection> m_collection;

WebServicePortID m_portID;

KURL m_targetURL;

- RefPtrWillBeMember<ScriptPromiseResolver> m_resolver;

+ Member<ScriptPromiseResolver> m_resolver;

enum State { Initial, Pending, Done };

State m_state;

« no previous file with comments | « Source/modules/mediastream/MediaDevicesRequest.h ('k') | Source/modules/navigatorconnect/ServicePortCollection.cpp » ('j') | no next file with comments »