Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5495)

Unified Diff: Source/modules/mediastream/MediaDevices.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/MediaDevices.cpp
diff --git a/Source/modules/mediastream/MediaDevices.cpp b/Source/modules/mediastream/MediaDevices.cpp
index 10c2377dd40d53e3553fc49793c8bde59e4a24fb..66cd9770b0cc9e28f7b5ed5395f866c0ff62de64 100644
--- a/Source/modules/mediastream/MediaDevices.cpp
+++ b/Source/modules/mediastream/MediaDevices.cpp
@@ -34,7 +34,7 @@ namespace {
class PromiseSuccessCallback final : public NavigatorUserMediaSuccessCallback {
public:
- PromiseSuccessCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit PromiseSuccessCallback(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
}
@@ -55,12 +55,12 @@ public:
}
private:
- RefPtrWillBeMember<ScriptPromiseResolver> m_resolver;
+ Member<ScriptPromiseResolver> m_resolver;
};
class PromiseErrorCallback final : public NavigatorUserMediaErrorCallback {
public:
- PromiseErrorCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver)
+ explicit PromiseErrorCallback(ScriptPromiseResolver* resolver)
: m_resolver(resolver)
{
}
@@ -81,14 +81,14 @@ public:
}
private:
- RefPtrWillBeMember<ScriptPromiseResolver> m_resolver;
+ Member<ScriptPromiseResolver> m_resolver;
};
} // namespace
ScriptPromise MediaDevices::getUserMedia(ScriptState* scriptState, const Dictionary& options, ExceptionState& exceptionState)
{
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
NavigatorUserMediaSuccessCallback* successCallback = new PromiseSuccessCallback(resolver);
NavigatorUserMediaErrorCallback* errorCallback = new PromiseErrorCallback(resolver);
« no previous file with comments | « Source/modules/imagebitmap/WindowImageBitmapFactories.cpp ('k') | Source/modules/mediastream/MediaDevicesRequest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698