Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2416)

Unified Diff: Source/modules/crypto/CryptoResultImpl.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/crypto/CryptoResultImpl.h
diff --git a/Source/modules/crypto/CryptoResultImpl.h b/Source/modules/crypto/CryptoResultImpl.h
index a54e1d8364d04a78d63bb70bfb21ad3fe3f7d87f..50b640ea71efed6c39f1612c9805746018289717 100644
--- a/Source/modules/crypto/CryptoResultImpl.h
+++ b/Source/modules/crypto/CryptoResultImpl.h
@@ -49,13 +49,13 @@ MODULES_EXPORT ExceptionCode webCryptoErrorToExceptionCode(WebCryptoErrorType);
//
// * At creation time there must be an active ExecutionContext.
// * All methods of the CryptoResult implementation must be called from
-// the origin thread. The exception is that ref(), deref(), and
-// destruction may happen on another thread.
+// the origin thread. The exception is that destruction may happen on
+// another thread.
// * One of the completeWith***() functions must be called, or the
// m_resolver will be leaked until the ExecutionContext is destroyed.
class CryptoResultImpl final : public CryptoResult {
public:
- static PassRefPtrWillBeRawPtr<CryptoResultImpl> create(ScriptState*);
+ static CryptoResultImpl* create(ScriptState*);
~CryptoResultImpl();
@@ -100,7 +100,7 @@ private:
void cancel();
void clearResolver();
- RawPtrWillBeMember<Resolver> m_resolver;
+ Member<Resolver> m_resolver;
// Separately communicate cancellation to WebCryptoResults so as to
// allow this result object, which will be on the Oilpan heap, to be
« no previous file with comments | « Source/modules/credentialmanager/CredentialsContainer.cpp ('k') | Source/modules/crypto/CryptoResultImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698