Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: Source/modules/background_sync/SyncCallbacks.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/background_sync/SyncCallbacks.h
diff --git a/Source/modules/background_sync/SyncCallbacks.h b/Source/modules/background_sync/SyncCallbacks.h
index fbc7d9f77c486e691d4ca568a4e93a3845a0dffc..6e42a64fd45c3fb180c93f0f671789278e0a6b7a 100644
--- a/Source/modules/background_sync/SyncCallbacks.h
+++ b/Source/modules/background_sync/SyncCallbacks.h
@@ -28,14 +28,14 @@ class WebString;
class SyncRegistrationCallbacks final : public WebSyncRegistrationCallbacks {
WTF_MAKE_NONCOPYABLE(SyncRegistrationCallbacks);
public:
- SyncRegistrationCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, ServiceWorkerRegistration*);
+ SyncRegistrationCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~SyncRegistrationCallbacks() override;
void onSuccess(WebSyncRegistration*) override;
void onError(WebSyncError*) override;
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
Persistent<ServiceWorkerRegistration> m_serviceWorkerRegistration;
};
@@ -47,14 +47,14 @@ private:
class SyncUnregistrationCallbacks final : public WebSyncUnregistrationCallbacks {
WTF_MAKE_NONCOPYABLE(SyncUnregistrationCallbacks);
public:
- SyncUnregistrationCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, ServiceWorkerRegistration*);
+ SyncUnregistrationCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~SyncUnregistrationCallbacks() override;
void onSuccess(bool*) override;
void onError(WebSyncError*) override;
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
Persistent<ServiceWorkerRegistration> m_serviceWorkerRegistration;
};
@@ -65,14 +65,14 @@ private:
class SyncGetRegistrationsCallbacks final : public WebSyncGetRegistrationsCallbacks {
WTF_MAKE_NONCOPYABLE(SyncGetRegistrationsCallbacks);
public:
- SyncGetRegistrationsCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, ServiceWorkerRegistration*);
+ SyncGetRegistrationsCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~SyncGetRegistrationsCallbacks() override;
void onSuccess(WebVector<WebSyncRegistration*>*) override;
void onError(WebSyncError*) override;
private:
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+ Persistent<ScriptPromiseResolver> m_resolver;
Persistent<ServiceWorkerRegistration> m_serviceWorkerRegistration;
};
@@ -82,7 +82,7 @@ private:
class SyncGetPermissionStatusCallbacks final : public WebSyncGetPermissionStatusCallbacks {
WTF_MAKE_NONCOPYABLE(SyncGetPermissionStatusCallbacks);
public:
- SyncGetPermissionStatusCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, ServiceWorkerRegistration*);
+ SyncGetPermissionStatusCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~SyncGetPermissionStatusCallbacks() override;
void onSuccess(WebSyncPermissionStatus*) override;
@@ -90,7 +90,8 @@ public:
private:
static String permissionString(WebSyncPermissionStatus);
- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;
+
+ Persistent<ScriptPromiseResolver> m_resolver;
Persistent<ServiceWorkerRegistration> m_serviceWorkerRegistration;
};
« no previous file with comments | « Source/modules/background_sync/PeriodicSyncRegistration.cpp ('k') | Source/modules/background_sync/SyncCallbacks.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698