Source/modules/audio_output_devices/SetSinkIdCallbacks.h - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/audio_output_devices/SetSinkIdCallbacks.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp ('k') | Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/audio_output_devices/SetSinkIdCallbacks.h

diff --git a/Source/modules/audio_output_devices/SetSinkIdCallbacks.h b/Source/modules/audio_output_devices/SetSinkIdCallbacks.h

index 0bcb6196bc685c3cc14de10b62f6ea91c7f0e5d8..0a3572a4186d00716d81ca87b15ad7fc9abf7ac0 100644

--- a/Source/modules/audio_output_devices/SetSinkIdCallbacks.h

+++ b/Source/modules/audio_output_devices/SetSinkIdCallbacks.h

@@ -9,7 +9,6 @@

#include "platform/heap/Handle.h"

#include "public/platform/WebCallbacks.h"

#include "wtf/Noncopyable.h"

-#include "wtf/PassRefPtr.h"

#include "wtf/RefPtr.h"

namespace blink {

@@ -21,14 +20,14 @@ struct WebSetSinkIdError;

class SetSinkIdCallbacks final : public WebCallbacks<void, WebSetSinkIdError*> {

WTF_MAKE_NONCOPYABLE(SetSinkIdCallbacks);

public:

- SetSinkIdCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>, HTMLMediaElement&, const String& sinkId);

+ SetSinkIdCallbacks(ScriptPromiseResolver*, HTMLMediaElement&, const String& sinkId);

~SetSinkIdCallbacks() override;

void onSuccess() override;

void onError(WebSetSinkIdError*) override;

private:

- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

+ Persistent<ScriptPromiseResolver> m_resolver;

RefPtrWillBePersistent<HTMLMediaElement> m_element;

String m_sinkId;

};