Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: Source/core/streams/ReadableStreamReader.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix webusb ScriptPromiseResolver usage Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/streams/ReadableStreamImpl.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/streams/ReadableStreamReader.cpp
diff --git a/Source/core/streams/ReadableStreamReader.cpp b/Source/core/streams/ReadableStreamReader.cpp
index 81f4f863c5d47bde2ff69c96f5298838a4f1cf72..5f7912d26821451de70959d847d2d1fb0e9c6676 100644
--- a/Source/core/streams/ReadableStreamReader.cpp
+++ b/Source/core/streams/ReadableStreamReader.cpp
@@ -52,7 +52,7 @@ ScriptPromise ReadableStreamReader::cancel(ScriptState* scriptState, ScriptValue
return m_stream->cancelInternal(scriptState, reason);
// A method should return a different promise on each call.
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
resolver->resolve(closed(scriptState).v8Value());
return promise;
@@ -67,7 +67,7 @@ ScriptPromise ReadableStreamReader::read(ScriptState* scriptState)
return ScriptPromise::cast(scriptState, v8IteratorResultDone(scriptState));
}
// A method should return a different promise on each call.
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
resolver->resolve(closed(scriptState).v8Value());
return promise;
« no previous file with comments | « Source/core/streams/ReadableStreamImpl.h ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698