Source/modules/webmidi/MIDIAccessInitializer.h - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webmidi/MIDIAccessInitializer.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: keepAliveWhilePending() comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/webmidi/MIDIAccessInitializer.h

diff --git a/Source/modules/webmidi/MIDIAccessInitializer.h b/Source/modules/webmidi/MIDIAccessInitializer.h

index 9f18ac1ebb14756986a853a88585e72fcea2fcf9..943ad4d0dc652b59f025bc5097c0d0b8965fc96b 100644

--- a/Source/modules/webmidi/MIDIAccessInitializer.h

+++ b/Source/modules/webmidi/MIDIAccessInitializer.h

@@ -40,7 +40,7 @@ public:

static ScriptPromise start(ScriptState* scriptState, const MIDIOptions& options)

{

- RefPtrWillBeRawPtr<MIDIAccessInitializer> resolver = adoptRefWillBeNoop(new MIDIAccessInitializer(scriptState, options));

+ MIDIAccessInitializer* resolver = new MIDIAccessInitializer(scriptState, options);

resolver->keepAliveWhilePending();

resolver->suspendIfNeeded();

return resolver->start();

« no previous file with comments | « Source/modules/webaudio/RealtimeAnalyser.cpp ('k') | Source/platform/CryptoResult.h » ('j') | Source/platform/heap/Handle.h » ('J')