Source/modules/push_messaging/PushSubscriptionCallbacks.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: keepAliveWhilePending() comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

diff --git a/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp b/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

index 546f3a748cf9c99d14bc1992f9b034d611174848..80ecf4f30efdb8dfcbfb15fdcb15730e5dd6f467 100644

--- a/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

+++ b/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

@@ -12,7 +12,7 @@

namespace blink {

-PushSubscriptionCallbacks::PushSubscriptionCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

+PushSubscriptionCallbacks::PushSubscriptionCallbacks(ScriptPromiseResolver* resolver, ServiceWorkerRegistration* serviceWorkerRegistration)

: m_resolver(resolver)

, m_serviceWorkerRegistration(serviceWorkerRegistration)

{

« no previous file with comments | « Source/modules/push_messaging/PushSubscriptionCallbacks.h ('k') | Source/modules/quota/StorageQuota.cpp » ('j') | Source/platform/heap/Handle.h » ('J')