Source/modules/push_messaging/PushPermissionStatusCallbacks.h - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushPermissionStatusCallbacks.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: keepAliveWhilePending() comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/push_messaging/PushManager.cpp ('k') | Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp » ('j') | Source/platform/heap/Handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushPermissionStatusCallbacks.h

diff --git a/Source/modules/push_messaging/PushPermissionStatusCallbacks.h b/Source/modules/push_messaging/PushPermissionStatusCallbacks.h

index 89cf867e25111dbcc2df2cf38280208efb4e38da..838d443c4e637a56fb2d5876ed899967cd2a0b89 100644

--- a/Source/modules/push_messaging/PushPermissionStatusCallbacks.h

+++ b/Source/modules/push_messaging/PushPermissionStatusCallbacks.h

@@ -9,8 +9,6 @@

#include "public/platform/modules/push_messaging/WebPushPermissionStatus.h"

#include "public/platform/modules/push_messaging/WebPushProvider.h"

#include "wtf/Noncopyable.h"

-#include "wtf/PassRefPtr.h"

-#include "wtf/RefPtr.h"

namespace WTF {

class String;

@@ -25,7 +23,7 @@ class PushPermissionStatusCallbacks final : public WebPushPermissionStatusCallba

WTF_MAKE_NONCOPYABLE(PushPermissionStatusCallbacks);

public:

- explicit PushPermissionStatusCallbacks(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>);

+ explicit PushPermissionStatusCallbacks(ScriptPromiseResolver*);

~PushPermissionStatusCallbacks() override;

void onSuccess(WebPushPermissionStatus*) override;

@@ -35,7 +33,7 @@ public:

private:

static WTF::String permissionString(WebPushPermissionStatus);

- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

+ Persistent<ScriptPromiseResolver> m_resolver;

};

} // namespace blink