Source/modules/presentation/PresentationRequest.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/presentation/PresentationRequest.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: keepAliveWhilePending() comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/presentation/PresentationAvailabilityCallback.cpp ('k') | Source/modules/presentation/PresentationSessionClientCallbacks.h » ('j') | Source/platform/heap/Handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/presentation/PresentationRequest.cpp

diff --git a/Source/modules/presentation/PresentationRequest.cpp b/Source/modules/presentation/PresentationRequest.cpp

index 0e5d2d20f6cb10e80c67ad05cee268ca9b2578a3..143d029088834ef07c31e1169f00924e9031316e 100644

--- a/Source/modules/presentation/PresentationRequest.cpp

+++ b/Source/modules/presentation/PresentationRequest.cpp

@@ -47,7 +47,7 @@ bool PresentationRequest::hasPendingActivity() const

ScriptPromise PresentationRequest::start(ScriptState* scriptState)

{

// TODO(mlamouri): migrate from Presentation, see https://crbug.com/510483

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

return promise;

}

@@ -55,7 +55,7 @@ ScriptPromise PresentationRequest::start(ScriptState* scriptState)

ScriptPromise PresentationRequest::join(ScriptState* scriptState, const String& id)

{

// TODO(mlamouri): migrate from Presentation, see https://crbug.com/510483

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

return promise;

}

@@ -63,7 +63,7 @@ ScriptPromise PresentationRequest::join(ScriptState* scriptState, const String&

ScriptPromise PresentationRequest::getAvailability(ScriptState* scriptState)

{

// TODO(mlamouri): migrate from Presentation, see https://crbug.com/510483

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

return promise;

}