Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: Source/modules/presentation/Presentation.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: keepAliveWhilePending() comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/presentation/Presentation.cpp
diff --git a/Source/modules/presentation/Presentation.cpp b/Source/modules/presentation/Presentation.cpp
index e53d092a450e2f51f87a158d554b284307a6fb95..7700a9ba37352c61937663fb36d3df0e2d2f454d 100644
--- a/Source/modules/presentation/Presentation.cpp
+++ b/Source/modules/presentation/Presentation.cpp
@@ -87,7 +87,7 @@ PresentationSession* Presentation::session() const
ScriptPromise Presentation::startSession(ScriptState* state, const String& presentationUrl)
{
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(state);
ScriptPromise promise = resolver->promise();
WebPresentationClient* client = presentationClient(executionContext());
@@ -102,7 +102,7 @@ ScriptPromise Presentation::startSession(ScriptState* state, const String& prese
ScriptPromise Presentation::joinSession(ScriptState* state, const String& presentationUrl, const String& presentationId)
{
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(state);
ScriptPromise promise = resolver->promise();
WebPresentationClient* client = presentationClient(executionContext());
@@ -117,7 +117,7 @@ ScriptPromise Presentation::joinSession(ScriptState* state, const String& presen
ScriptPromise Presentation::getAvailability(ScriptState* state, const String& presentationUrl)
{
- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(state);
+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(state);
ScriptPromise promise = resolver->promise();
WebPresentationClient* client = presentationClient(executionContext());

Powered by Google App Engine
This is Rietveld 408576698