Source/modules/serviceworkers/ServiceWorkerClients.cpp - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerClients.cpp

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/mediastream/MediaDevices.cpp ('K') | « Source/modules/screen_orientation/ScreenOrientation.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerClients.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerClients.cpp b/Source/modules/serviceworkers/ServiceWorkerClients.cpp

index 1da6a873c54ff7a7607e084d77155295f642e9f2..ae21d1945dc16c533a553b89eefd4fba3627f229 100644

--- a/Source/modules/serviceworkers/ServiceWorkerClients.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerClients.cpp

@@ -77,7 +77,7 @@ ScriptPromise ServiceWorkerClients::matchAll(ScriptState* scriptState, const Cli

if (!executionContext)

return ScriptPromise();

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

WebServiceWorkerClientQueryOptions webOptions;

@@ -95,7 +95,7 @@ ScriptPromise ServiceWorkerClients::claim(ScriptState* scriptState)

if (!executionContext)

return ScriptPromise();

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

WebServiceWorkerClientsClaimCallbacks* callbacks = new CallbackPromiseAdapter<void, ServiceWorkerError>(resolver);

@@ -105,7 +105,7 @@ ScriptPromise ServiceWorkerClients::claim(ScriptState* scriptState)

ScriptPromise ServiceWorkerClients::openWindow(ScriptState* scriptState, const String& url)

{

- RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);

ScriptPromise promise = resolver->promise();

ExecutionContext* context = scriptState->executionContext();