Source/modules/screen_orientation/LockOrientationCallback.h - Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/screen_orientation/LockOrientationCallback.h

Issue 1233173002: Have ScriptPromiseResolver on the Oilpan heap always. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: smaller review updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/mediastream/MediaDevices.cpp ('K') | « Source/modules/quota/StorageQuotaCallbacksImpl.cpp ('k') | Source/modules/screen_orientation/LockOrientationCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/screen_orientation/LockOrientationCallback.h

diff --git a/Source/modules/screen_orientation/LockOrientationCallback.h b/Source/modules/screen_orientation/LockOrientationCallback.h

index b984362f0ad9311e6f8896e5302d0566f5b4e872..74bc20d45616cd5119394a8b6e9c0f9227d270ff 100644

--- a/Source/modules/screen_orientation/LockOrientationCallback.h

+++ b/Source/modules/screen_orientation/LockOrientationCallback.h

@@ -22,14 +22,14 @@ class ScriptPromiseResolver;

class LockOrientationCallback final : public WebLockOrientationCallback {

WTF_MAKE_NONCOPYABLE(LockOrientationCallback);

public:

- explicit LockOrientationCallback(PassRefPtrWillBeRawPtr<ScriptPromiseResolver>);

+ explicit LockOrientationCallback(ScriptPromiseResolver*);

~LockOrientationCallback() override;

void onSuccess() override;

void onError(WebLockOrientationError) override;

private:

- RefPtrWillBePersistent<ScriptPromiseResolver> m_resolver;

+ Persistent<ScriptPromiseResolver> m_resolver;

};

} // namespace blink